chore: relax username validation to include common special characters

fonoster · Feb 24, 2024 · 3af2e35 · 3af2e35
1 parent 6830e0e
commit 3af2e35
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/mods/common/src/connect/validations.ts b/mods/common/src/connect/validations.ts
@@ -38,14 +38,8 @@ export const hasUsername = (username: string) =>
   username ? true : new BadRequestError("the username is required")
 
 export const isValidUsername = (username: string) => {
-  if (
-    username &&
-    (!Validator.default.isAlphanumeric(username) ||
-      !Validator.default.isLowercase(username))
-  ) {
-    return new BadRequestError(
-      "the username must be a lowercase, alphanumeric, and without spaces"
-    )
+  if (username?.includes(" ")) {
+    return new BadRequestError("the username must not contain spaces")
   }
   return true
 }

diff --git a/mods/pgdata/test/agent.mapper.unit.test.ts b/mods/pgdata/test/agent.mapper.unit.test.ts
@@ -273,9 +273,7 @@ describe("@routr/pgdata/mappers/agent", () => {
       const result = () => new AgentManager(agent).validOrThrowCreate()
 
       // Assert
-      expect(result).to.throw(
-        "the username must be a lowercase, alphanumeric, and without spaces"
-      )
+      expect(result).to.throw("the username must not contain spaces")
     })
   })
 })
diff --git a/mods/pgdata/test/credentials.mapper.unit.test.ts b/mods/pgdata/test/credentials.mapper.unit.test.ts
@@ -193,12 +193,8 @@ describe("@routr/pgdata/mappers/credentials", () => {
         new CredentialsManager(credentials).validOrThrowUpdate()
 
       // Assert
-      expect(createResult).to.throw(
-        "the username must be a lowercase, alphanumeric, and without spaces"
-      )
-      expect(updateResult).to.throw(
-        "the username must be a lowercase, alphanumeric, and without spaces"
-      )
+      expect(createResult).to.throw("the username must not contain spaces")
+      expect(updateResult).to.throw("the username must not contain spaces")
     })
 
     it("when request is missing the password", () => {

diff --git a/mods/pgdata/test/peer.mapper.unit.test.ts b/mods/pgdata/test/peer.mapper.unit.test.ts
@@ -266,9 +266,7 @@ describe("@routr/pgdata/mappers/peer", () => {
       const result = () => new PeerManager(peer).validOrThrowCreate()
 
       // Assert
-      expect(result).to.throw(
-        "the username must be a lowercase, alphanumeric, and without spaces"
-      )
+      expect(result).to.throw("the username must not contain spaces")
     })
 
     it("when the request is missing the aor", () => {