refactor: Ruleset form sections and resource imports #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed export in resource index from mockRefdata to just refdata, in cases where we need to mock variables, we can rename the import at the test level, rather than the export as these resources will not always need to be mocked
Fixed imports for ruleset view test
Shifted around the file structure for the enumeration field array compoenents so that they can be more easily readable within the repository
Mored chronology field intop the chronology field array file
Moved combination field into combination field array file
moved omission field to omission field array component
Moved issue publication field compoenent to its associated field array
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently we have all components used within the ruleset form being stored at the top level of the directory, without them needing to be shared with multiple components, this PR moves the field components to within their respective field array components to improve readability
Additionally sorted imports of the mock refdata resource