UIIN-3187: ECS: Disable opening item details if a user is not affiliated with item's member tenant #2707
Conversation
mariia-aloshyna
requested review from
BogdanDenis,
Dmytro-Melnyshyn and
OleksandrHladchenko1
Jest Unit Test Statistics 1 files ±0 255 suites ±0 15m 2s ⏱️ +17s For more details on these failures, see this check. Results for commit 4efff99. ± Comparison against base commit 8657bbe. ♻️ This comment has been updated with latest results. |
|
| const isUserAffiliatedWithMemberTenant = checkIfUserInMemberTenant(stripes); | ||
|
|
||
| // if a user is not affiliated with the item's member tenant then item details cannot be open | ||
| if (!isUserAffiliatedWithMemberTenant) { | ||
| return instance; | ||
| } |
There was a problem hiding this comment.
This code prevents all member tenants from auto-openning the item view. Is this what you want? It looks like it also prevents all non-ECS users.
There was a problem hiding this comment.
Oh right, that's just me being stupid yesterday and thinking that the checkIfUserInMemberTenant function checks whether the user is affiliated with a member tenant. Ok, nevermind, I updated the PR
…ted with item's member tenant
mariia-aloshyna
force-pushed
the
UIIN-3187
branch
from
02cc133 to
4efff99
Compare
Purpose
When users are trying to find the item by barcode then they are getting error popup "Invalid token: User with id ... does not exist". It happens when there is only 1 search result and the item details page is trying to open, but the request failes because a user is not affiliated with the item's member tenant.
Approach
Refs
https://folio-org.atlassian.net/browse/UIIN-3187
Screenshots