UIIN-1933 correctly place/omit accordion separators (#1652)

Several accordions' separators were incorrect, probably as a result of copy-paste accordions as new filters were added. Refs UIIN-1933
folio-org · Apr 10, 2022 · 75c46b8 · 75c46b8
1 parent 6c5ace6
commit 75c46b8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/src/components/HoldingsRecordFilters/HoldingsRecordFilters.js b/src/components/HoldingsRecordFilters/HoldingsRecordFilters.js
@@ -184,7 +184,6 @@ const HoldingsRecordFilters = (props) => {
         label={<FormattedMessage id="ui-inventory.statisticalCode" />}
         id={FACETS.HOLDINGS_STATISTICAL_CODE_IDS}
         name={FACETS.HOLDINGS_STATISTICAL_CODE_IDS}
-        separator={false}
         closedByDefault
         header={FilterAccordionHeader}
         displayClearButton={activeFilters[FACETS.HOLDINGS_STATISTICAL_CODE_IDS]?.length > 0}

diff --git a/src/components/InstanceFilters/InstanceFilters.js b/src/components/InstanceFilters/InstanceFilters.js
@@ -183,7 +183,6 @@ const InstanceFilters = props => {
         label={<FormattedMessage id={`ui-inventory.instances.${FACETS.LANGUAGE}`} />}
         id={FACETS.LANGUAGE}
         name={FACETS.LANGUAGE}
-        separator={false}
         closedByDefault
         header={FilterAccordionHeader}
         displayClearButton={activeFilters[FACETS.LANGUAGE]?.length > 0}
@@ -319,7 +318,6 @@ const InstanceFilters = props => {
         label={<FormattedMessage id="ui-inventory.statisticalCode" />}
         id={FACETS.STATISTICAL_CODE_IDS}
         name={FACETS.STATISTICAL_CODE_IDS}
-        separator={false}
         closedByDefault
         header={FilterAccordionHeader}
         displayClearButton={activeFilters[FACETS.STATISTICAL_CODE_IDS]?.length > 0}

diff --git a/src/components/ItemFilters/ItemFilters.js b/src/components/ItemFilters/ItemFilters.js
@@ -135,6 +135,7 @@ const ItemFilters = (props) => {
         header={FilterAccordionHeader}
         displayClearButton={!_.isEmpty(activeFilters[FACETS.ITEM_STATUS])}
         onClearFilter={() => onClear(FACETS.ITEM_STATUS)}
+        separator={false}
       >
         <CheckboxFacet
           name={FACETS.ITEM_STATUS}
@@ -151,7 +152,6 @@ const ItemFilters = (props) => {
         label={<FormattedMessage id={`ui-inventory.filters.${FACETS.EFFECTIVE_LOCATION}`} />}
         id={FACETS.EFFECTIVE_LOCATION}
         name={FACETS.EFFECTIVE_LOCATION}
-        separator
         header={FilterAccordionHeader}
         displayClearButton={activeFilters[FACETS.EFFECTIVE_LOCATION]?.length > 0}
         onClearFilter={() => onClear(FACETS.EFFECTIVE_LOCATION)}
@@ -191,7 +191,6 @@ const ItemFilters = (props) => {
         label={<FormattedMessage id={`ui-inventory.${FACETS.MATERIAL_TYPE}`} />}
         id={FACETS.MATERIAL_TYPE}
         name={FACETS.MATERIAL_TYPE}
-        separator
         closedByDefault
         header={FilterAccordionHeader}
         displayClearButton={!_.isEmpty(activeFilters[FACETS.MATERIAL_TYPE])}
@@ -231,7 +230,6 @@ const ItemFilters = (props) => {
         label={<FormattedMessage id="ui-inventory.statisticalCode" />}
         id={FACETS.ITEMS_STATISTICAL_CODE_IDS}
         name={FACETS.ITEMS_STATISTICAL_CODE_IDS}
-        separator={false}
         closedByDefault
         header={FilterAccordionHeader}
         displayClearButton={activeFilters[FACETS.ITEMS_STATISTICAL_CODE_IDS]?.length > 0}