Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ASF 3rd Party License Policy for module evaluation #79

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MODULE_ACCEPTANCE_CRITERIA.MD
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ Please see [Before Development](MODULE_EVALUATION_TEMPLATE#before-development) f
* _This is not applicable to libraries_
* Module descriptor MUST include interface requirements for all consumed APIs (3, 5)
* _This is not applicable to libraries_
* Third party dependencies use an Apache 2.0 compatible license (2)
* Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html) (2)
julianladisch marked this conversation as resolved.
Show resolved Hide resolved
* org.z3950.zing:cql-java is allowed, even if it is LGPL-2.1-only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why you noted this exception, and it makes sense to me. But is there any action we should take for

This criterium can be changed as soon as better third party requirements get proposed.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, anyone can raise a proposal for better third party requirements at any time.

* Installation documentation is included (11)
* -_note: read more at https://github.com/folio-org/mod-search/blob/master/README.md_
* _This is not applicable to libraries_
Expand Down
3 changes: 2 additions & 1 deletion MODULE_EVALUATION_TEMPLATE.MD
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ When performing a technical evaluation of a module, create a copy of this docume
* [ ] Uses Apache 2.0 license
* [ ] Module build MUST produce a valid module descriptor
* [ ] Module descriptor MUST include interface requirements for all consumed APIs
* [ ] Third party dependencies use an Apache 2.0 compatible license
* [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html)
* org.z3950.zing:cql-java is allowed, even if it is LGPL-2.1-only
* [ ] Installation documentation is included
* -_note: read more at https://github.com/folio-org/mod-search/blob/master/README.md_
* [ ] Personal data form is completed, accurate, and provided as `PERSONAL_DATA_DISCLOSURE.md` file
Expand Down