Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAT-17417 Support automated test cases #4668

Merged
merged 5 commits into from
Jan 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.waitFileUploading();

BulkEditSearchPane.verifyMatchedResults(testData.user.username);
BulkEditSearchPane.verifyPaneRecordsCount(1);
BulkEditSearchPane.verifyPaneRecordsCount('1 user');
BulkEditSearchPane.isDragAndDropAreaDisabled(true);

BulkEditSearchPane.selectRecordIdentifier('User Barcodes');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.checkForUploading(userUUIDsFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyErrorLabel(userUUIDsFileName, 1, 1);
BulkEditSearchPane.verifyPaneRecordsCount(1);
BulkEditSearchPane.verifyPaneRecordsCount('1 user');
BulkEditSearchPane.verifyMatchedResults(user.username);
BulkEditSearchPane.verifyNonMatchedResults(invalidUserUUID);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,16 @@ describe('bulk-edit', () => {
BulkEditActions.verifyOptionsDropdown();
BulkEditActions.isSelectActionAbsent();
BulkEditActions.selectOption('URL Relationship');
let possibleActions = ['Clear field', 'Find', 'Replace with'];
let possibleActions = ['Clear field', 'Find (full field search)', 'Replace with'];
BulkEditActions.verifyPossibleActions(possibleActions);
BulkEditActions.selectSecondAction('Clear field');
BulkEditActions.addNewBulkEditFilterString();
BulkEditActions.verifyNewBulkEditRow();
BulkEditActions.verifyOptionAbsentInNewRow('URL Relationship');
BulkEditActions.deleteRow(1);
BulkEditActions.findValue('URL Relationship');
BulkEditActions.selectOption('URL Relationship');
BulkEditActions.selectSecondAction('Find (full field search)');
BulkEditActions.verifyActionSelected('Find (full field search)');
possibleActions = ['Replace with', 'Remove'];
BulkEditActions.verifyPossibleActions(possibleActions);
BulkEditActions.selectSecondAction('Remove');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ describe('bulk-edit', () => {
);
BulkEditSearchPane.verifyElectronicAccessElementByIndex(4, electronicAccess[0].publicNote);
BulkEditActions.openInAppStartBulkEditFrom();
BulkEditActions.electronicAccessReplaceWith(
'URL Relationship',
BulkEditActions.urlRelationshipReplaceWith(
electronicAccessRelationshipName.RESOURCE,
electronicAccessRelationshipName.VERSION_OF_RESOURCE,
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ describe('bulk-edit', () => {
`${notes.exhibitionsNote} (staff only)`,
);

BulkEditSearchPane.verifyErrorLabelInErrorAccordion(instanceUUIDsFileName, 2, 2, 3);
BulkEditSearchPane.verifyNonMatchedResults(marcInstance.instanceId);
BulkEditSearchPane.verifyErrorLabel(3);
BulkEditSearchPane.verifyNonMatchedResults(marcInstance.instanceId, `${reasonForError} `);
BulkEditSearchPane.verifyReasonForError(reasonForError);

BulkEditActions.openActions();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('bulk-edit', () => {

const instanceNoteColumnNames = Object.values(
BULK_EDIT_TABLE_COLUMN_HEADERS.INVENTORY_INSTANCES,
).slice(22);
).slice(23);

BulkEditSearchPane.verifyInstanceNoteColumns(instanceNoteColumnNames);
BulkEditSearchPane.changeShowColumnCheckboxIfNotYet(
Expand Down Expand Up @@ -261,7 +261,7 @@ describe('bulk-edit', () => {
BulkEditActions.commitChanges();
BulkEditSearchPane.waitFileUploading();
BulkEditActions.verifySuccessBanner(1);
BulkEditSearchPane.verifyPaneRecordsChangedCount(1);
BulkEditSearchPane.verifyPaneRecordsChangedCount('1 instance');
BulkEditSearchPane.verifyExactChangesUnderColumnsByIdentifierInChangesAccordion(
instance.hrid,
BULK_EDIT_TABLE_COLUMN_HEADERS.INVENTORY_INSTANCES.ADMINISTRATIVE_NOTE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.uploadFile(instanceUUIDsFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyPaneTitleFileName(instanceUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(`${numberOfRecords}`);
BulkEditSearchPane.verifyPaneRecordsCount(`${numberOfRecords} instance`);
BulkEditSearchPane.verifyFileNameHeadLine(instanceUUIDsFileName);

createdInstanceHrids.forEach((instanceHrid, index) => {
Expand All @@ -112,11 +112,11 @@ describe('bulk-edit', () => {
);
});

BulkEditSearchPane.verifyErrorLabel(
instanceUUIDsFileName,
numberOfRecords,
numberOfRecords,
);
BulkEditSearchPane.verifyErrorLabel(10);

invalidInstanceIds.forEach((invalidInstanceId) => {
BulkEditSearchPane.verifyNonMatchedResults(invalidInstanceId);
});

createdInstanceHrids.forEach((instanceHrid) => {
BulkEditSearchPane.verifyExactChangesUnderColumnsByIdentifierInResultsAccordion(
Expand Down Expand Up @@ -146,12 +146,6 @@ describe('bulk-edit', () => {
);
});

BulkEditSearchPane.verifyNonMatchedResults();

invalidInstanceIds.forEach((invalidInstanceId) => {
BulkEditSearchPane.verifyReasonForErrorByIdentifier(invalidInstanceId, 'No match found ');
});

BulkEditSearchPane.verifyActionsAfterConductedInAppUploading(true, true);
BulkEditSearchPane.verifyInstanceActionShowColumns();
BulkEditSearchPane.uncheckShowColumnCheckbox(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.uploadFile(instanceUUIDsFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyPaneTitleFileName(instanceUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount('6');
BulkEditSearchPane.verifyPaneRecordsCount('6 instance');
BulkEditSearchPane.verifyFileNameHeadLine(instanceUUIDsFileName);

createdInstanceHrids.forEach((instanceHrid) => {
Expand All @@ -281,7 +281,7 @@ describe('bulk-edit', () => {
);
});

BulkEditSearchPane.verifyErrorLabel(instanceUUIDsFileName, 6, 5);
BulkEditSearchPane.verifyErrorLabel(5);
BulkEditActions.openActions();
BulkEditSearchPane.changeShowColumnCheckboxIfNotYet(
BULK_EDIT_TABLE_COLUMN_HEADERS.INVENTORY_INSTANCES.SUPPRESS_FROM_DISCOVERY,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.uploadFile(instanceUUIDsFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyPaneTitleFileName(instanceUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount('6');
BulkEditSearchPane.verifyPaneRecordsCount('6 instance');
BulkEditSearchPane.verifyFileNameHeadLine(instanceUUIDsFileName);

createdInstanceHrids.forEach((instanceHrid) => {
Expand All @@ -273,7 +273,7 @@ describe('bulk-edit', () => {
);
});

BulkEditSearchPane.verifyErrorLabel(instanceUUIDsFileName, 6, 5);
BulkEditSearchPane.verifyErrorLabel(5);
BulkEditActions.openActions();
BulkEditSearchPane.changeShowColumnCheckboxIfNotYet(
BULK_EDIT_TABLE_COLUMN_HEADERS.INVENTORY_INSTANCES.SUPPRESS_FROM_DISCOVERY,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ describe('bulk-edit', () => {
BulkEditActions.commitChanges();
BulkEditSearchPane.waitFileUploading();
BulkEditActions.verifySuccessBanner(1);
BulkEditSearchPane.verifyPaneRecordsChangedCount(1);
BulkEditSearchPane.verifyPaneRecordsChangedCount('1 item');

updatedNotesHeaderValueSets.forEach((updatedNoteHeaderValue) => {
BulkEditSearchPane.verifyExactChangesUnderColumnsByIdentifierInChangesAccordion(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.waitFileUploading();

BulkEditSearchPane.verifyErrorLabel(invalidHoldingUUIDsFileName, 0, 1);
BulkEditSearchPane.verifyPaneRecordsCount(0);
BulkEditSearchPane.verifyPaneRecordsCount('0 holding');
BulkEditSearchPane.verifyNonMatchedResults();
BulkEditActions.openActions();
BulkEditActions.downloadMatchedRecordsAbsent();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('bulk-edit', () => {
// Download matched records
BulkEditActions.downloadMatchedResults();
BulkEditSearchPane.verifyMatchedResults(item.firstBarcode);
BulkEditSearchPane.verifyPaneRecordsCount(1);
BulkEditSearchPane.verifyPaneRecordsCount('1 item');
BulkEditActions.openInAppStartBulkEditFrom();
BulkEditActions.verifyRowIcons();
// Select "Temporary item location" from "Options" dropdown and "Replace with" option from "Select option" dropdown;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.checkForUploading(usernamesFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyErrorLabel(usernamesFileName, 1, 1);
BulkEditSearchPane.verifyPaneRecordsCount(1);
BulkEditSearchPane.verifyPaneRecordsCount('1 user');
BulkEditSearchPane.verifyMatchedResults(user.username);

// Click "Actions" menu
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.uploadFile(instanceHRIDFileName);
BulkEditSearchPane.checkForUploading(instanceHRIDFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyPaneRecordsCount(2);
BulkEditSearchPane.verifyPaneRecordsCount('2 holding');

BulkEditActions.downloadMatchedResults();
BulkEditFiles.verifyMatchedResultFileContent(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.waitFileUploading();
// Check the result of uploading the .csv file with Items barcodes
BulkEditSearchPane.verifyMatchedResults(item.itemBarcode);
BulkEditSearchPane.verifyPaneRecordsCount(1);
BulkEditSearchPane.verifyPaneRecordsCount('1 item');
// Click "Actions" menu => Select "Start Bulk edit" option
BulkEditActions.openActions();
BulkEditActions.openInAppStartBulkEditFrom();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,12 @@ describe('bulk-edit', () => {
]);
BulkEditActions.commitChanges();
BulkEditActions.verifySuccessBanner(0);
BulkEditSearchPane.verifyErrorLabelAfterChanges(instanceHRIDFileName, 0, 2);
BulkEditSearchPane.verifyErrorLabel(2);

[hridValues.folioHrid, hridValues.marcHrid].forEach((hrid) => {
BulkEditSearchPane.verifyErrorByIdentifier(hrid, 'No change in value required');
});

BulkEditActions.openActions();
BulkEditActions.downloadErrors();
ExportFile.verifyFileIncludes(errorsFromCommittingFileName, [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe('bulk-edit', () => {
`${folioItem.instanceId},false,true,`,
`${marcInstances[0].instanceId},false,true,`,
`${unsuppressedFolioItem.instanceId},false,false,`,
`${marcInstances[1].instanceId},false,,`,
`${marcInstances[1].instanceId},false,false,`,
]);
BulkEditActions.openStartBulkEditInstanceForm();
BulkEditActions.verifyModifyLandingPageBeforeModifying();
Expand Down Expand Up @@ -152,11 +152,13 @@ describe('bulk-edit', () => {
unsuppressedFolioItem.instanceId,
marcInstances[1].instanceId,
);
BulkEditSearchPane.verifyNonMatchedResults(
folioItem.instanceId,
marcInstances[0].instanceId,
);
BulkEditSearchPane.verifyErrorLabelAfterChanges(instanceUUIDsFileName, 2, 2);

BulkEditSearchPane.verifyErrorLabel(2);

[folioItem.instanceId, marcInstances[0].instanceId].forEach((instanceId) => {
BulkEditSearchPane.verifyErrorByIdentifier(instanceId, 'No change in value required');
});

BulkEditActions.openActions();
BulkEditActions.downloadChangedCSV();
BulkEditActions.downloadErrors();
Expand Down Expand Up @@ -187,7 +189,7 @@ describe('bulk-edit', () => {
`${folioItem.instanceId},false,true,`,
`${marcInstances[0].instanceId},false,true,`,
`${unsuppressedFolioItem.instanceId},false,false,`,
`${marcInstances[1].instanceId},false,,`,
`${marcInstances[1].instanceId},false,false,`,
]);

BulkEditLogs.downloadFileWithProposedChanges();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('bulk-edit', () => {
BulkEditSearchPane.uploadFile(userUUIDsFileName);
BulkEditSearchPane.waitFileUploading();
BulkEditSearchPane.verifyErrorLabel(userUUIDsFileName, 0, 1);
BulkEditSearchPane.verifyPaneRecordsCount(0);
BulkEditSearchPane.verifyPaneRecordsCount('0 user');
BulkEditSearchPane.verifyNonMatchedResults();

// Navigate to the "Export manager" app
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

const holdingHrids = [...collegeHoldingHrids, ...universityHoldingHrids];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

const holdingHrids = [...collegeHoldingHrids, ...universityHoldingHrids];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

const holdingHrids = [...collegeHoldingHrids, ...universityHoldingHrids];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(2);
BulkEditSearchPane.verifyPaneRecordsCount('2 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

instances.forEach((instance) => {
Expand Down Expand Up @@ -304,7 +304,7 @@ describe('Bulk-edit', () => {
);
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(2);
BulkEditSearchPane.verifyPaneRecordsCount('2 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

instances.forEach((instance) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

const holdingHrids = [...collegeHoldingHrids, ...universityHoldingHrids];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Holdings', 'Holdings UUIDs');
BulkEditSearchPane.uploadFile(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(holdingUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 holding');
BulkEditSearchPane.verifyFileNameHeadLine(holdingUUIDsFileName);

const holdingHrids = [...collegeHoldingHrids, ...universityHoldingHrids];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
APPLICATION_NAMES,
BULK_EDIT_TABLE_COLUMN_HEADERS,
ITEM_STATUS_NAMES,
LOAN_TYPE_NAMES,
} from '../../../../support/constants';
import TopMenuNavigation from '../../../../support/fragments/topMenuNavigation';

Expand Down Expand Up @@ -75,7 +76,7 @@ describe('Bulk-edit', () => {
cy.getLocations({ query: 'name="DCB"' }).then((res) => {
locationId = res.id;
});
cy.getLoanTypes({ limit: 1 }).then((res) => {
cy.getLoanTypes({ query: `name="${LOAN_TYPE_NAMES.CAN_CIRCULATE}"` }).then((res) => {
loanTypeId = res[0].id;
});
cy.getMaterialTypes({ limit: 1 }).then((res) => {
Expand Down Expand Up @@ -183,7 +184,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Items', 'Item UUIDs');
BulkEditSearchPane.uploadFile(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(2);
BulkEditSearchPane.verifyPaneRecordsCount('2 item');
BulkEditSearchPane.verifyFileNameHeadLine(itemUUIDsFileName);

const itemBarcodes = [folioInstance.barcodeInCollege, marcInstance.barcodeInCollege];
Expand Down Expand Up @@ -294,7 +295,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Items', 'Item UUIDs');
BulkEditSearchPane.uploadFile(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(2);
BulkEditSearchPane.verifyPaneRecordsCount('2 item');
BulkEditSearchPane.verifyFileNameHeadLine(itemUUIDsFileName);

itemBarcodes.forEach((barcode) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ describe('Bulk-edit', () => {
BulkEditSearchPane.verifyDragNDropRecordTypeIdentifierArea('Items', 'Item UUIDs');
BulkEditSearchPane.uploadFile(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneTitleFileName(itemUUIDsFileName);
BulkEditSearchPane.verifyPaneRecordsCount(4);
BulkEditSearchPane.verifyPaneRecordsCount('4 item');
BulkEditSearchPane.verifyFileNameHeadLine(itemUUIDsFileName);

const itemBarcodes = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
APPLICATION_NAMES,
BULK_EDIT_TABLE_COLUMN_HEADERS,
ITEM_STATUS_NAMES,
LOAN_TYPE_NAMES,
} from '../../../../support/constants';
import TopMenuNavigation from '../../../../support/fragments/topMenuNavigation';

Expand Down Expand Up @@ -94,7 +95,7 @@ describe('Bulk-edit', () => {
cy.getLocations({ query: 'name="DCB"' }).then((res) => {
locationId = res.id;
});
cy.getLoanTypes({ limit: 1 }).then((res) => {
cy.getLoanTypes({ query: `name="${LOAN_TYPE_NAMES.CAN_CIRCULATE}"` }).then((res) => {
loanTypeId = res[0].id;
});
cy.getMaterialTypes({ limit: 1 }).then((res) => {
Expand Down
Loading
Loading