Spitfire bf nonECS fixes 1/22

cypress/e2e/data-import/importing-marc-bib-files/update-tag-value-of-linked-marcBib-controlled-by-marcAuth.cy.js

@@ -167,7 +167,7 @@ describe('Data Import', () => {
           .then(() => {
             TopMenuNavigation.openAppFromDropdown(APPLICATION_NAMES.INVENTORY);
             InventoryInstances.searchByTitle(createdAuthorityIDs[0]);
-            InventoryInstances.selectInstance();
+            InventoryInstances.selectInstanceById(createdAuthorityIDs[0]);
             InventoryInstance.editMarcBibliographicRecord();
             linkingTagAndValues.forEach((linking) => {
               QuickMarcEditor.clickLinkIconInTagField(linking.rowIndex);
@@ -245,7 +245,7 @@ describe('Data Import', () => {
       { tags: ['extendedPath', 'spitfire', 'C374189'] },
       () => {
         InventoryInstances.searchByTitle(createdAuthorityIDs[0]);
-        InventoryInstances.selectInstance();
+        InventoryInstances.selectInstanceById(createdAuthorityIDs[0]);
         // download .csv file
         InventorySearchAndFilter.saveUUIDs();
         ExportFile.downloadCSVFile(nameForCSVFile, 'SearchInstanceUUIDs*');
@@ -278,8 +278,8 @@ describe('Data Import', () => {
         Logs.verifyInstanceStatus(0, 3, RECORD_STATUSES.UPDATED);
 
         TopMenuNavigation.navigateToApp(APPLICATION_NAMES.INVENTORY);
-        InventoryInstances.searchByTitle(testData.instanceTitle);
-        InventoryInstances.selectInstance();
+        InventoryInstances.searchByTitle(createdAuthorityIDs[0]);
+        InventoryInstances.selectInstanceById(createdAuthorityIDs[0]);
         InventoryInstance.checkAbsenceOfAuthorityIconInInstanceDetailPane('Contributor');
         InventoryInstance.editMarcBibliographicRecord();
         QuickMarcEditor.verifyTagFieldAfterUnlinking(...testData.updated110Field);

cypress/e2e/eholdings/package/attach-package-to-existing-agreement.cy.js

@@ -19,9 +19,9 @@ describe('eHoldings', () => {
     before('Creating usera and creating data', () => {
       cy.createTempUser([
         Permissions.uiAgreementsAgreementsEdit.gui,
-        Permissions.uiAgreementsSearchAndView,
+        Permissions.uiAgreementsSearchAndView.gui,
         Permissions.uieHoldingsRecordsEdit.gui,
-        Permissions.uiAgreementsSearch,
+        Permissions.uiAgreementsSearch.gui,
       ])
         .then((createdUserProperties) => {
           testData.userProperties = createdUserProperties;

cypress/e2e/marc/marc-authority/create-marc-authority/create-new-marcAuth-record-with-folio-authority-file.cy.js

@@ -97,6 +97,8 @@ describe('MARC', () => {
           MarcAuthority.contains(newFields[0].content);
           MarcAuthorities.closeMarcViewPane();
           MarcAuthorities.verifyMarcViewPaneIsOpened(false);
+          // workaround for an issue when detailed view is not opened when using a filter after record creation - team won't fix it
+          cy.reload();
           MarcAuthorities.checkRecordsResultListIsAbsent();
           MarcAuthorities.searchBy(testData.searchOption, testData.marcValue);
           MarcAuthorities.checkAfterSearch(testData.AUTHORIZED, testData.marcValue);

cypress/e2e/marc/marc-authority/create-marc-authority/create-new-marcAuth-record-with-local-auth-file-with-default-prefix.cy.js

@@ -115,7 +115,8 @@ describe('MARC', () => {
           // 7 Close the detail view pane by clicking on "X" icon placed in the left upper corner of the pane
           MarcAuthorities.closeMarcViewPane();
           MarcAuthorities.verifyMarcViewPaneIsOpened(false);
-
+          // workaround for an issue when detailed view is not opened when using a filter after record creation - team won't fix it
+          cy.reload();
           // 8 Click on the "Authority source" multi select element in "Authority source" accordion placed on "Search & filter" pane
           MarcAuthorities.clickMultiSelectToggleButtonInAccordion('Authority source');
           MarcAuthorities.checkAuthoritySourceDropdownHasOption(localAuthFile.name);

cypress/e2e/marc/marc-authority/create-marc-authority/create-new-marcAuth-record-with-local-authority-file.cy.js

@@ -119,6 +119,8 @@ describe('MARC', () => {
           // 7 Close the detail view pane by clicking on "X" icon placed in the left upper corner of the pane
           MarcAuthorities.closeMarcViewPane();
           MarcAuthorities.verifyMarcViewPaneIsOpened(false);
+          // workaround for an issue when detailed view is not opened when using a filter after record creation - team won't fix it
+          cy.reload();
 
           // 8 Click on the "Authority source" multi select element in "Authority source" accordion placed on "Search & filter" pane
           MarcAuthorities.clickMultiSelectToggleButtonInAccordion('Authority source');

cypress/e2e/marc/marc-authority/edit-authority-record/user-cannot-delete-value-from-$a-subfield-of-010-field-in-linked-record-when-010-$0.cy.js

@@ -22,7 +22,7 @@ describe('MARC', () => {
           keyword: 'Keyword',
           nameTitle: 'C376936 Roberts',
         },
-        errorMessage: 'Cannot remove 010 $a for this record.',
+        errorMessage: 'Cannot delete 010. It is required.',
         bib700AfterLinkingToAuth100: [
           56,
           '700',
@@ -152,12 +152,11 @@ describe('MARC', () => {
           QuickMarcEditor.pressSaveAndClose();
           cy.wait(1500);
           QuickMarcEditor.pressSaveAndClose();
-
-          QuickMarcEditor.checkErrorMessage(4, testData.errorMessage);
+          QuickMarcEditor.checkCallout(testData.errorMessage);
           QuickMarcEditor.clickSaveAndKeepEditingButton();
           cy.wait(1500);
           QuickMarcEditor.clickSaveAndKeepEditingButton();
-          QuickMarcEditor.checkErrorMessage(4, testData.errorMessage);
+          QuickMarcEditor.checkCallout(testData.errorMessage);
           QuickMarcEditor.pressCancel();
           MarcAuthorities.checkDetailViewIncludesText(
             `${testData.subfieldPrefix} ${testData.tag010content}`,

cypress/e2e/marc/marc-authority/edit-linked-authority-record/add-edit-$z-and-delete-$a-$z-in-010-field-of-linked-marcAuth-record-when-001-controls-$0.cy.js

@@ -161,8 +161,6 @@ describe('MARC', () => {
             tag010.inputContent.field010_2,
           );
           QuickMarcEditor.checkButtonsEnabled();
-          QuickMarcEditor.clickSaveAndKeepEditingButton();
-          cy.wait(1500);
           QuickMarcEditor.pressSaveAndKeepEditing(testData.calloutMessage);
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_2, tag010.rowIndex);
 
@@ -172,16 +170,12 @@ describe('MARC', () => {
           );
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_3, tag010.rowIndex);
           QuickMarcEditor.checkButtonsEnabled();
-          QuickMarcEditor.clickSaveAndKeepEditingButton();
-          cy.wait(1500);
           QuickMarcEditor.pressSaveAndKeepEditing(testData.calloutMessage);
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_3, tag010.rowIndex);
           cy.wait(3000);
 
           QuickMarcEditor.updateExistingFieldContent(4, tag010.inputContent.field010_4);
           QuickMarcEditor.checkButtonsEnabled();
-          QuickMarcEditor.clickSaveAndKeepEditingButton();
-          cy.wait(1500);
           QuickMarcEditor.pressSaveAndKeepEditing(testData.calloutMessage);
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_1, tag010.rowIndex);
 
@@ -191,8 +185,6 @@ describe('MARC', () => {
           );
           QuickMarcEditor.checkButtonsEnabled();
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_4, tag010.rowIndex);
-          QuickMarcEditor.clickSaveAndKeepEditingButton();
-          cy.wait(1500);
           QuickMarcEditor.pressSaveAndKeepEditing(testData.calloutMessage);
           QuickMarcEditor.checkContent(tag010.expectedContent.field010_4, tag010.rowIndex);
 

cypress/e2e/marc/marc-authority/edit-linked-authority-record/edit-010-value-adding-valid-prefix-in-$a-of-marc-auth-record-when-001-controls-$0-of-marc-bib.cy.js

@@ -40,7 +40,8 @@ describe('MARC', () => {
       const viewSourceData = [
         'Linked to MARC authority',
         '100',
-        '$0 http://id.loc.gov/authorities/names/n80036674 $9 26daa178-09b0-4a44-ac23-d76c2eda0091 $a C422066 Kerouac, Jack (001 has valid prefix), $d 1922-1969 $e author.',
+        '$0 http://id.loc.gov/authorities/names/n80036674',
+        '$a C422066 Kerouac, Jack (001 has valid prefix), $d 1922-1969 $e author.',
       ];
 
       const marcFiles = [

cypress/e2e/marc/marc-authority/edit-linked-authority-record/marc-authority-edit-110-field-value-which-controls-marc-bib.cy.js

@@ -20,7 +20,7 @@ describe('MARC', () => {
         tagsForChanging: ['100', '101', '110', '111', '130', '150', '151', '155'],
         createdRecordIDs: [],
         searchOption: 'Keyword',
-        marcValue: 'Best, Pete,',
+        marcValue: 'C374139 Best, Pete,',
         errorMessageAfterChangingTag:
           'Cannot change the saved MARC authority field 110 because it controls a bibliographic field(s). To change this 1XX, you must unlink all controlled bibliographic fields.',
         errorMessageAfterSaving: 'Record cannot be saved without 1XX field.',

cypress/e2e/marc/marc-authority/edit-linked-authority-record/marc-authority-edit-subfield-0-controlled-field.cy.js

@@ -136,9 +136,9 @@ describe('MARC', () => {
             `Linked to MARC authority\n${marcFiles[1].valueAfterSave}`,
           );
           InventoryInstance.viewSource();
-          InventoryViewSource.contains(
-            'Linked to MARC authority\n\t700\t1  \t$a C374157 Roberts, Julia, $d 1967- $e Actor. $0 http://id.loc.gov/authorities/names/n91074081',
-          );
+          InventoryViewSource.contains('Linked to MARC authority\n\t700\t1  \t');
+          InventoryViewSource.contains('$a C374157 Roberts, Julia, $d 1967- $e Actor.');
+          InventoryViewSource.contains('$0 http://id.loc.gov/authorities/names/n91074081');
         },
       );
     });

cypress/e2e/marc/marc-authority/edit-linked-authority-record/marc-authority-edit-update-of-010-update-bib-field-with-001.cy.js

@@ -17,14 +17,14 @@ describe('MARC', () => {
         tag100: '100',
         tag010: '010',
         tag010NewValue: '$a  00000912  $z n 2005070769',
-        authority100FieldValue: 'Erbil, H. Yıldırım',
+        authority100FieldValue: 'C376595 Auto Erbil, H. Yıldırım',
         searchOption: 'Keyword',
         linked100Field: [
           16,
           '100',
           '1',
           '\\',
-          '$a Erbil, H. Yıldırım',
+          '$a C376595 Auto Erbil, H. Yıldırım',
           '',
           '$0 http://id.loc.gov/authorities/names/n00000912',
           '',
@@ -34,7 +34,7 @@ describe('MARC', () => {
           '100',
           '1',
           '\\',
-          '$a Erbil, H. Yıldırım',
+          '$a C376595 Auto Erbil, H. Yıldırım',
           '',
           '$0 http://id.loc.gov/authorities/names/n00000911',
           '',
@@ -58,7 +58,7 @@ describe('MARC', () => {
           fileName: `C376595 testMarcFileC376595${getRandomPostfix()}.mrc`,
           jobProfileToRun: DEFAULT_JOB_PROFILE_NAMES.CREATE_AUTHORITY,
           propertyName: 'authority',
-          authorityHeading: 'Erbil, H. Yıldırım',
+          authorityHeading: 'C376595 Auto Erbil, H. Yıldırım',
         },
       ];
 
@@ -67,6 +67,7 @@ describe('MARC', () => {
       before('Create test data', () => {
         cy.createTempUser([Permissions.moduleDataImportEnabled.gui]).then((userProperties) => {
           testData.preconditionUserId = userProperties.userId;
+          MarcAuthorities.deleteMarcAuthorityByTitleViaAPI('C376595*');
 
           marcFiles.forEach((marcFile) => {
             DataImport.uploadFileViaApi(

cypress/e2e/marc/marc-authority/reporting-marc-authority/marc-autority-reporting-updated-heading.cy.js

@@ -31,7 +31,7 @@ describe('MARC', () => {
         updatedTag100Value:
           '$a C357220 Beethoven, Ludwig the Greatest, $d 1770-1827. $t Variations, $m piano, violin, cello, $n op. 44, $r E♭ major',
         title:
-          'Beethoven, Ludwig van, 1770-1827. Variations, piano, violin, cello, op. 44, E♭ major',
+          'C375220 Beethoven, Ludwig van, 1770-1827. Variations, piano, violin, cello, op. 44, E♭ major',
       };
       const today = DateTools.getFormattedDate({ date: new Date() }, 'MM/DD/YYYY');
       const todayWithoutPaddingZero = DateTools.clearPaddingZero(today);

cypress/e2e/marc/marc-bibliographic/derive-marc-bib/manual-linking/derive-restore-deleted-and-saved-linked-field-of-marcBib-record-in-deriving-window.cy.js

@@ -144,7 +144,7 @@ describe('MARC', () => {
             QuickMarcEditor.deleteField(32);
             QuickMarcEditor.afterDeleteNotification(testData.tag100);
             QuickMarcEditor.pressSaveAndClose();
-            cy.wait(1500);
+            cy.wait(2000);
             QuickMarcEditor.clickSaveAndCloseThenCheck(1);
             QuickMarcEditor.checkDeletingFieldsModal();
             QuickMarcEditor.clickRestoreDeletedField();
@@ -153,6 +153,8 @@ describe('MARC', () => {
             QuickMarcEditor.updateExistingField(testData.tag245, testData.tag245content);
             QuickMarcEditor.checkButtonSaveAndCloseEnable();
             QuickMarcEditor.pressSaveAndClose();
+            cy.wait(2000);
+            QuickMarcEditor.pressSaveAndClose();
             QuickMarcEditor.checkCallout('Record created.');
             InstanceRecordView.verifyInstancePaneExists();
             InventoryInstance.verifyContributor(

cypress/e2e/marc/marc-bibliographic/edit-marc-bib/manual-linking/user-can't-link-bibField240-with-wrong-record.cy.js

@@ -160,6 +160,7 @@ describe('MARC', () => {
               QuickMarcEditor.checkCallout(testData.errorMessage);
               InventoryInstance.verifySelectMarcAuthorityModal();
               MarcAuthorities.closeAuthoritySourceOption();
+              MarcAuthorities.verifyNoSourceOptionsSelected();
             });
           },
         );