-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
STCOM-1056 prevent null in state.layoutCache (#1907)
Yeah it's pretty clear, can't have no nulls, fool! So I can index, index, like I'm supposed to do Can't have no boom boom when changing column spaces I need all the right punc in all the right places I see the state init, it reads initial props But it don't check for null, so reading dot-paths stops If you got braces braces, just post 'em up So you can index an array and you don't ever have to stop Yeah John Coburn, he told me, "You got to initialize!" Be like, "If props come in null then defaults will not override." And so when props come in empty we add our own brand new stash So traversing the state doesn't blow up on null layoutCache Because you know it's all about that brace Supersedes #1095, which was insufficient. Refs STCOM-1056, again
- Loading branch information
Showing
2 changed files
with
26 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters