-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODTLR-69 Merge ecs-tlr-feature branch into master #71
Merged
+7,690
−782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nked to an item (#20) * MODTLR-13 Use Kafka from Testcontainers * MODTLR-13 Enable system user * MODTLR-20 Create DCB transactions when secondary request is linked to an item * MODTLR-20 Use constructor injection for DcbService * MODTLR-20 Additional check in test * MODTLR-20 Fix formatting * MODTLR-20 Fix permission for DCB-transactions * MODTLR-20 Fix URL for DCB-transactions API * MODTLR-20 Improve logging * MODTLR-20 Comment out code for BORROWER transactions * MODTLR-20 Create DCB transactions in different tenants * MODTLR-20 debug: create system user for tenant "college" * Revert "MODTLR-20 debug: create system user for tenant "college"" This reverts commit db4bc19. * MODTLR-20 Tests refactoring * MODTLR-20 Fix logging (cherry picked from commit c42306a)
* MODTLR-17 Create service points client * MODTLR-20 debug: create system user for tenant "college" * Revert "MODTLR-20 debug: create system user for tenant "college"" This reverts commit db4bc19. * MODTLR-17 Implementation and tests * MODTLR-17 Test refactoring * MODTLR-17 Remove TenantScopedExecutionService * MODTLR-17 Copy more properties to secondary request service point * MODTLR-17 Use UnaryOperator instead of a Function * MODTLR-17 Extend tests * MODTLR-17 Extract replication into service * MODTLR-17 Use constructor injection in replication services * MODTLR-17 Use singular in client names * MODTLR-17 Add all permissions to system user * MODTLR-17 Do replication in current tenant * MODTLR-17 Clone pickup location flag * MODTLR-17 Clone hold shelf expiration period * MODTLR-17 Do not clone username * MODTLR-17 Replication -> cloning
#30) * MODTLR-27 Remove unneeded fields from the requester copy, update group * MODTLR-27 Remove unneeded fields from the requester copy, update group * MODTLR-27 Remove unneeded fields from the requester copy, update group * MODTLR-27 Remove unneeded fields from the requester copy, update group * ЬЩВЕДК-27 Apply suggestions from code review Co-authored-by: OleksandrVidinieiev <56632770+OleksandrVidinieiev@users.noreply.github.com> --------- Co-authored-by: Alexander Kurash <alexander.kurash@gmail.com> Co-authored-by: OleksandrVidinieiev <56632770+OleksandrVidinieiev@users.noreply.github.com>
* MODTLR-25 Initial implementation * MODTLR-25 Fix permission * MODTLR-25 Fix mapping * MODTLR-25 Fix tests * MODTLR-25 Revert redundant change * MODTLR-25 Revert pom * MODTLR-25 Fix schema * MODTLR-25 Fix lint errors and tests * MODTLR-25 Fix sonar issue
MODTLR-25 Add permission set
* MODTLR-26 Add operation param * MODTLR-26 Call data tenants * MODTLR-26 Revert generator version, fix tests * MODTLR-26 Add 422 test * MODTLR-26 Remove ecsRouting field * MODTLR-26 Fix implementation, add TODO * MODTLR-26 Change param name
* MODTLR-34 Update DCB transactions upon request update event * MODTLR-34 Remove RequestValidationException * MODTLR-34 Fix RequestEventHandlerTest * MODTLR-34 Fix code smells * MODTLR-34 Handle missing transaction * MODTLR-34 Do not update transaction when its status would not change * MODTLR-34 Add test case * MODTLR-34 Add test case * MODTLR-34 Remove TODOs * MODTLR-34 Refactoring * MODTLR-34 Refactoring
…API (#57) * MODTLR-56 Add support for operation `replace` in AllowedServicePoints API * MODTLR-56 Add test case * MODTLR-56 Remove redundant import * MODTLR-56 Always use stub item * MODTLR-56 Fix test * MODTLR-56 Logging and refactoring * MODTLR-56 Refactoring
…ersion (#59) * MODTLR-57: bump folio-spring-system-user version * MODTLR-57: Add env variable SYSTEM_USER_ENABLED * MODTLR-57: add env var section into README.md * MODTLR-57: fix from code review * MODTLR-57: remove redundant jpa declaration * MODTLR-57: remove unused env variables from module descriptor
[MODTLR-43] Reorder secondary requests in sync with primary requests [Part 2]
* MODTLR-67 Extract token from headers if it's not found in cookies * MODTLR-67 Make method static * MODTLR-67 Improve logging * MODTLR-67 Refactoring * MODTLR-67 Add test case * MODTLR-67 Remove 'public' modifier from test class
* MODTLR-59: Add item-level logic to allowed service points api * MODTLR-59: Add test * MODTLR-59: Remove redundant itemId check * MODTLR-59: Reformat code * MODTLR-59: Reformat code * MODTLR-59: Fix from code review * MODTLR-59: ADD abstract factory to invoke different scenarios * MODTLR-59: ADD itemId param for replace operation check * MODTLR-59: Refactor * MODTLR-59: Decompose methods extracting abstract behaviour * MODTLR-59: Revert indentation * MODTLR-59 Refactoring * MODTLR-59: Fix from code review * MODTLR-59: ADD item validation --------- Co-authored-by: Oleksandr Vidinieiev <oleksandr_vidinieiev@epam.com>
* MODTLR-61 Use regular create request endpoint * MODTLR-65 Use regular request endpoint * MODTLR-65 Add holdingsRecordId to ECS TLR entity * MODTLR-65 Add holdingsRecordId column * MODTLR-65 Create circulation item * MODTLR-65 Add system user permissions * MODTLR-65 Change circulation item mapping * MODTLR-65 Fix circulation item client * MODTLR-65 Use fixed holdings record ID * MODTLR-65 Fix primary request type * MODTLR-65 Use different status for circ item * MODTLR-65 Get itemId from secondary request * MODTLR-60 add reordering for ILR queue * MODTLR-65 Check for existing circulation item * MODTLR-60 conflicts resolving * MODTLR-73 Check for existing circulation item * MODTLR-73 Change POST to PUT * MODTLR-73 fix broken tests * MODTLR73 remove redundant dependency * MODTLR-73 remove redundant feign configuration * MODTLR-73 add logging * MODTLR-73 remove instanceId from required fields * MODTLR-73 revert instanceId required field, add logging * MODTLR-73 fix code smells * MODTLR-73 fix NPE * MODTLR-73 make tests parameterized * MODTLR-73 make test parameterized * MODTLR-73 fix code smell * MODTLR-73 add parameters to test * MODTLR-73 add unit tests * MODTLR-73 add unit tests --------- Co-authored-by: alexanderkurash <alexander.kurash@gmail.com>
* add missed permission * add missed permission
[MODTLR-73] Add missed module permissions
[MODTLR-73] Add missing module and system user permissions
# Conflicts: # pom.xml # src/main/resources/application.yml
roman-barannyk
approved these changes
Nov 1, 2024
|
AntonAntonich
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODTLR-69 Merge custom branch ecs-tlr-feature into master
Approach
mod-tlr will not be released to community until Sunflower, feature toggle is not required.
We need to make sure that this merge doesn't brake Snapshot builds because of the interface versions conflict.