MODTLR-16: Create shadow requester in remote renant #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrVidinieiev
requested review from
MagzhanArtykov,
alexanderkurash and
roman-barannyk
|
Comment on lines
+39
to
+56
| tenantScopedExecutionService.execute(remoteTenantId, () -> { | ||
| try { | ||
| User existingShadowUser = usersClient.getUser(userId); | ||
| log.info("createShadowUser:: user {} found in remote tenant ({}), doing nothing", | ||
| userId, remoteTenantId); | ||
| log.debug("createShadowUser:: existing shadow user: {}", () -> existingShadowUser); | ||
| return null; | ||
| } catch (FeignException.NotFound e) { | ||
| log.info("createShadowUser:: user {} not found in remote tenant ({})", userId, remoteTenantId); | ||
| } | ||
| log.info("createShadowUser:: creating shadow user {} in remote tenant ({})", userId, remoteTenantId); | ||
| User newShadowUser = usersClient.postUser(buildShadowUser(realUser)); | ||
| log.info("createShadowUser:: shadow user {} created in remote tenant ({})", | ||
| newShadowUser.getId(), remoteTenantId); | ||
| log.debug("createShadowUser:: created shadow user: {}", () -> newShadowUser); | ||
|
|
||
| return newShadowUser; | ||
| }); |
There was a problem hiding this comment.
How about considering moving the lambda expression to a separate method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create shadow-copy of a requester in remote (target) tenant
Approach
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.