MODTLR-75 Remove redundant methods

folio-org · Nov 29, 2024 · fd8ce3c · fd8ce3c
1 parent 87d175f
commit fd8ce3c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 23 deletions.
diff --git a/src/main/java/org/folio/service/InventoryService.java b/src/main/java/org/folio/service/InventoryService.java
@@ -14,10 +14,8 @@
 
 public interface InventoryService {
   Collection<Item> findItems(CqlQuery query, String idIndex, Collection<String> ids);
-  Collection<Item> findItems(Collection<String> ids);
   Collection<HoldingsRecord> findHoldings(CqlQuery query, String idIndex, Collection<String> ids);
   Collection<HoldingsRecord> findHoldings(Collection<String> ids);
-  Collection<Instance> findInstances(CqlQuery query, String idIndex, Collection<String> ids);
   Collection<Instance> findInstances(Collection<String> ids);
   Collection<MaterialType> findMaterialTypes(Collection<String> ids);
   Collection<LoanType> findLoanTypes(Collection<String> ids);

diff --git a/src/main/java/org/folio/service/impl/InventoryServiceImpl.java b/src/main/java/org/folio/service/impl/InventoryServiceImpl.java
@@ -56,13 +56,6 @@ public Collection<Item> findItems(CqlQuery query, String idIndex, Collection<Str
     return BulkFetcher.fetch(itemClient, query, idIndex, ids, Items::getItems);
   }
 
-  @Override
-  public Collection<Item> findItems(Collection<String> ids) {
-    log.info("findItems:: searching items by {} IDs", ids::size);
-    log.debug("findItems:: ids={}", ids);
-    return BulkFetcher.fetch(itemClient, ids, Items::getItems);
-  }
-
   @Override
   public Collection<HoldingsRecord> findHoldings(CqlQuery query, String idIndex, Collection<String> ids) {
     log.info("findHoldings:: searching holdings by query and index: query={}, index={}, ids={}",
@@ -77,13 +70,6 @@ public Collection<HoldingsRecord> findHoldings(Collection<String> ids) {
     return BulkFetcher.fetch(holdingClient, ids, HoldingsRecords::getHoldingsRecords);
   }
 
-  @Override
-  public Collection<Instance> findInstances(CqlQuery query, String idIndex, Collection<String> ids) {
-    log.info("findInstances:: searching instances by query and index: query={}, index={}, ids={}",
-      query, idIndex, ids.size());
-    log.debug("findInstances:: ids={}", ids);
-    return BulkFetcher.fetch(instanceClient, query, idIndex, ids, Instances::getInstances);
-  }
 
   @Override
   public Collection<Instance> findInstances(Collection<String> ids) {

diff --git a/src/test/java/org/folio/api/StaffSlipsApiTest.java b/src/test/java/org/folio/api/StaffSlipsApiTest.java
@@ -375,13 +375,6 @@ private static HoldingsRecord buildHolding(String instanceId, String locationId)
       .effectiveLocationId(locationId);
   }
 
-  private static HoldingsRecord buildHolding(String locationId) {
-    return new HoldingsRecord()
-      .id(randomId())
-      .copyNumber("Holding copy number")
-      .effectiveLocationId(locationId);
-  }
-
   private static Request buildRequest(Request.RequestTypeEnum requestTypeEnum,  String itemId,
     String holdingId, String instanceId, String requesterId) {