MODTLR-98 Fix code smells

folio-org · Dec 9, 2024 · 43252dd · 43252dd
1 parent 1dbf866
commit 43252dd
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/src/main/java/org/folio/service/impl/RequestServiceImpl.java b/src/main/java/org/folio/service/impl/RequestServiceImpl.java
@@ -139,7 +139,6 @@ public RequestWrapper createIntermediateRequest(Request intermediateRequest,
       final String requesterId = intermediateRequest.getRequesterId();
       final String pickupServicePointId = intermediateRequest.getPickupServicePointId();
 
-      // TODO: fetch both in one call to system user
       User primaryRequestRequester = executionService.executeSystemUserScoped(primaryRequestTenantId,
         () -> userService.find(requesterId));
       ServicePoint primaryRequestPickupServicePoint = executionService.executeSystemUserScoped(
@@ -210,7 +209,6 @@ public CirculationItem createCirculationItem(Request request, String inventoryTe
       return existingCirculationItem;
     }
 
-    // TODO: fetch both in one system user call
     InventoryItem item = getItemFromStorage(itemId, inventoryTenantId);
     InventoryInstance instance = getInstanceFromStorage(instanceId, inventoryTenantId);
 

diff --git a/src/test/java/org/folio/service/RequestServiceTest.java b/src/test/java/org/folio/service/RequestServiceTest.java
@@ -39,7 +39,6 @@ class RequestServiceTest {
   private Request secondaryRequest;
   private static final String ITEM_ID = UUID.randomUUID().toString();
   private static final String INSTANCE_ID = UUID.randomUUID().toString();
-  private static final String BORROWER_ID = UUID.randomUUID().toString();
   private static final String LENDER_ID = UUID.randomUUID().toString();
   private static final String HOLDINGS_RECORD_ID = "10cd3a5a-d36f-4c7a-bc4f-e1ae3cf820c9";
   private static final String LENDING_LIBRARY_CODE = "TEST_CODE";