Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODLD-639: Use latest Resource fetched from DB for emitting events #91

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Jan 13, 2025

No description provided.

@pkjacob pkjacob marked this pull request as draft January 13, 2025 15:20
@pkjacob pkjacob force-pushed the pjacob/MODLD-639 branch 6 times, most recently from 763d944 to a4bf8ba Compare January 17, 2025 14:56
@pkjacob pkjacob marked this pull request as ready for review January 17, 2025 16:11
assertTrue(resourceRepository.findById(work1.getId()).isEmpty());

// Assert that appropriate events are sent to mod-search
Set<ResourceIndexEvent> searchEventList = new HashSet<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor
var

);

// Assert that appropriate events are sent to inventory
Set<InstanceIngressEvent> inventoryEventList = new HashSet<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor
var

private MarcReaderProcessor marcReader;

@AfterEach
void clenUp() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? should be "cleanUp", no?

Copy link
Contributor Author

@pkjacob pkjacob Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thank You. I will correct in the next PR.

@@ -48,6 +49,11 @@ class ResourceControllerUpdateWorkIT {
@Autowired
private MarcReaderProcessor marcReader;

@AfterEach
void clenUp() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@pkjacob pkjacob merged commit 0257b6f into master Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants