MODLD-601: LCCN deduplication configuration setting #59
Conversation
src/main/resources/application.yml
Outdated
| @@ -82,6 +82,7 @@ mod-linked-data: | |||
| cache: | |||
| ttl: | |||
| spec-rules: ${CACHE_TTL_SPEC_RULES:18000000} | |||
| settings-entries: ${CACHE_TTL_SETTINGS_ENTRIES:18000000} | |||
There was a problem hiding this comment.
spring.cache.type=none can be used to disable all caches in karate tests
@pkjacob
src/main/resources/application.yml
Outdated
| @@ -82,6 +82,7 @@ mod-linked-data: | |||
| cache: | |||
| ttl: | |||
| spec-rules: ${CACHE_TTL_SPEC_RULES:18000000} | |||
| settings-entries: ${CACHE_TTL_SETTINGS_ENTRIES:18000000} | |||
There was a problem hiding this comment.
CACHE_TTL_SETTINGS_ENTRIES should be added to README and ModuleDescriptor files
| try { | ||
| return !settingsService.isSettingEnabled(DUPLICATE_CHECK_SCOPE, DUPLICATE_CHECK_KEY, DUPLICATE_CHECK_PROPERTY); | ||
| } catch (Exception e) { | ||
| return true; |
There was a problem hiding this comment.
maybe add some log here?
| @@ -81,8 +81,8 @@ mod-linked-data: | |||
| instance-ingress: ${KAFKA_INVENTORY_INSTANCE_INGRESS_EVENT_TOPIC:inventory.instance_ingress} | |||
| cache: | |||
| ttl: | |||
| spec-rules: ${CACHE_TTL_SPEC_RULES:18000000} | |||
| settings-entries: ${CACHE_TTL_SETTINGS_ENTRIES:18000000} | |||
| spec-rules: ${CACHE_TTL_SPEC_RULES_MS:18000000} | |||
|
|
||
| public interface SettingsService { | ||
|
|
||
| Optional<SettingsItem> getSetting(String scope, String key); |
There was a problem hiding this comment.
Any need to expose this method in the interface? I believe only isSettingEnabled need to be exposed in the interface and getSetting can be a private method in the impl class.
There was a problem hiding this comment.
just wanted to make it public for future usages, but yes, we ain't gonna need it now
There was a problem hiding this comment.
changed to private
| try { | ||
| return !settingsService.isSettingEnabled(DUPLICATE_CHECK_SCOPE, DUPLICATE_CHECK_KEY, DUPLICATE_CHECK_PROPERTY); | ||
| } catch (Exception e) { | ||
| log.warn("An exception occurred during settings service call", e); |
There was a problem hiding this comment.
decided to change it to 'error'
MODLD-601: Review fixes MODLD-601: Review fixes MODLD-601: Change log level for settings service outage
AndreiBordak
force-pushed
the
MODLD-601
branch
from
37e7bf8 to
4d1c0c7
Compare
|
No description provided.