Do not import kubernetes in flytekit core

[thomasjpfan]

Tracking issue

Follow up to #2943

Why are the changes needed?

Since flytekit does not depend on kubernetes, importing flytekit will not work anymore if kubernetes is not installed.

What changes were proposed in this pull request?

This PR moves the imports out of the top level and into the function.

How was this patch tested?

Built an image with this PR and not kubernetes and make sure it works:

from flytekit import ImageSpec, task

image = ImageSpec(registry="localhost:30000", copy=["flytekit"])


@task(container_image=image)
def hello() -> str:
    return "hello world"

Ideally we also have a CI job that does not have kubernetes installed to make sure flytekit still works.

Summary by Bito

Optimization of kubernetes dependency handling in Flytekit by making it optional and lightweight, while also enhancing the authentication system through factory pattern implementation and lazy loading capabilities. The changes include moving kubernetes-related imports to function scope, implementing environment variable validation in Secret class, and improving credential management with better refresh mechanisms.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 2

[flyte-bot]

Code Review Agent Run #6680ec

Actionable Suggestions - 0

Additional Suggestions - 1

• flytekit/core/resources.py - 1

  • Consider simplifying type hint usage · Line 111-111

Review Details

• Files reviewed - 3 · Commit Range: 29a0748..29a0748

  • flytekit/core/resources.py
  • flytekit/core/task.py
  • flytekit/models/task.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Feature Improvement - Optimize Kubernetes Import Dependencies	- resources.py - Moved kubernetes imports to function scope and added TYPE_CHECKING - task.py - Relocated kubernetes ApiClient import to class scope - pyproject.toml - Removed kubernetes dependency from project requirements

[eapolinario]

what do you think of adding an extra called kubernetes (and require that package there)?

[thomasjpfan]

what do you think of adding an extra called kubernetes (and require that package there)?

It's either flytekit[kubernetes] or flytekit[podt-emplate]. I like the second one more, since it's based on a flytekit feature.

[eapolinario]

what do you think of adding an extra called kubernetes (and require that package there)?

It's either flytekit[kubernetes] or flytekit[podt-emplate]. I like the second one more, since it's based on a flytekit feature.

agreed.

[Future-Outlier]

should we remove kubernetes>=12.0.1 in pyproject.toml?
https://github.com/flyteorg/flytekit/blob/master/pyproject.toml#L36

[thomasjpfan]

Ah I see. I did not know kubernetes was added as a dependency.

[eapolinario]

wait, we can still remove it, right? Adding a 2MB dependency that doesn't get used all the time seems like a waste.

[eapolinario]

another great argument for removing kubernetes as a dependency (again) is because it wasn't put back in an official release yet (as per 2da64ef - only 1.15 beta releases).

[thomasjpfan]

Updated PR to remove kubernetes as a direct dependency.

[eapolinario]

this was a leftover from a test you were running, right?

[thomasjpfan]

Ah I forgot to remove this. I reverted the change.

[flyte-bot]

Code Review Agent Run #860995

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 29a0748..ab627d2

  • pyproject.toml
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (ef6d7d4) to head (0ec5b54).

Files with missing lines	Patch %	Lines
flytekit/models/task.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3118      +/-   ##
==========================================
- Coverage   76.08%   76.06%   -0.03%     
==========================================
  Files         203      203              
  Lines       21609    21609              
  Branches     2782     2782              
==========================================
- Hits        16442    16437       -5     
- Misses       4346     4349       +3     
- Partials      821      823       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[flyte-bot]

Code Review Agent Run #6dbf04

Actionable Suggestions - 0

Review Details

• Files reviewed - 10 · Commit Range: ab627d2..0ec5b54

  • flytekit/clients/auth_helper.py
  • flytekit/clients/grpc_utils/auth_interceptor.py
  • flytekit/core/task.py
  • flytekit/models/security.py
  • pyproject.toml
  • tests/flytekit/unit/clients/auth/test_keyring_store.py
  • tests/flytekit/unit/clients/test_auth_helper.py
  • tests/flytekit/unit/clients/test_friendly.py
  • tests/flytekit/unit/clients/test_raw.py
  • tests/flytekit/unit/models/core/test_security.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[kumare3]

Can we just make sure we get a good error if it is not installed and needed at compile time. We can ask folks to install it