Enable "error prone" library that does static code analysis during code compilation #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
changed the title
asolntsev
force-pushed
the
refactor/error-prone
branch
from
e746151 to
4d14841
Compare
in these cases, system default locale/charset is used, which can cause unpredictable behavour and random errors.
instead of arrays, let's operate with old good java objects: RGBColor and HSBColor.
e.g. "Key" or "newInstance()".
* remove unused field `dim` * replace `setDocument` methods by constructor with document parameter.
previously, it didn't remove anything because `imageComponents` key type is `CacheKey`, not `Element`. P.S. But it seems that this `remove` method is not used at all.
.. to allow running `BrowserStartup` Swing application.
asolntsev
force-pushed
the
refactor/error-prone
branch
from
0255194 to
7785f59
Compare
asolntsev
force-pushed
the
refactor/error-prone
branch
from
5da0ffe to
b34084f
Compare
…The result of `parseStylesheet(...)` must be used"
asolntsev
force-pushed
the
refactor/error-prone
branch
from
7fe64d9 to
181e348
Compare
asolntsev
force-pushed
the
refactor/error-prone
branch
from
cec21d3 to
fa617c1
Compare
it's better to specify UTF-8 charset explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.