Yet another RootPanel NPE fix. And general bonus-cleanup. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- documentListeners is now Set<DocumentListener> instead of Map - added protected hasDocumentListeners() method - using foreach for documentListeners iteration - moved addDocumentListener and removeDocumentListener from BasicPanel to RootPanel - fixed null handling of addDocumentListener and removeDocumentListener according to javadoc - documentListeners is now private and final
- enclosingScrollPane is now private - added protected getEnclosingScrollPane() - removed BasicPanel.getFixedRectangle() because it was identical to RootPanel implementation. This ensures that initialization performed in setEnclosingScrollPane can’t be circumvented.
|
Thanks! |
|
I've released this as https://github.com/flyingsaucerproject/flyingsaucer/releases/tag/v9.1.4 yesterday. It's available on Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, another NPE lurked in
getScrollableTracksViewportHeight().I didn't immediately spot it because those happen in
addNotify/removeNotifycontext and are thus easy to miss.I have taken the opportunity to sanity-check every single usage of
enclosingScrollPaneand identified some more places that didn't perform necessary null checks. Fixed them.Since FS requires Java 6 anyway, I also streamlined handling of
documentListenersin 9078cf8, preventing more potential NPEs (according to documentation) and cleaning up the code in the process.Access to
documentListenersandenclosingScrollPanehas been locked down. This introduces potential compile-time compatibility issues for people extendingRootPanel/BasicPanelbut changes necessary to fix them are very straightforward.@pbrant My previous PR aimed to be minimal. This one aims to be thorough. Sorry for the hassle.