[refactoring] rename "HRef" to "href"

flyingsaucerproject · Dec 28, 2023 · e100566 · e100566
1 parent 4bd37f9
commit e100566
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 30 deletions.
diff --git a/flying-saucer-pdf-itext5/src/main/java/org/xhtmlrenderer/pdf/ITextOutputDevice.java b/flying-saucer-pdf-itext5/src/main/java/org/xhtmlrenderer/pdf/ITextOutputDevice.java
@@ -998,15 +998,15 @@ private void loadBookmark(Bookmark parent, Element bookmark) {
     }
 
     static class Bookmark {
-        private String _name;
-        private String _HRef;
-        private Box    _box;
+        private final String _name;
+        private final String _href;
+        private Box _box;
 
         private List<Bookmark> _children;
 
         Bookmark(String name, String href) {
             _name = name;
-            _HRef = href;
+            _href = href;
         }
 
         public Box getBox() {
@@ -1018,21 +1018,13 @@ public void setBox(Box box) {
         }
 
         public String getHRef() {
-            return _HRef;
-        }
-
-        public void setHRef(String href) {
-            _HRef = href;
+            return _href;
         }
-
+        
         public String getName() {
             return _name;
         }
 
-        public void setName(String name) {
-            _name = name;
-        }
-
         public void addChild(Bookmark child) {
             if (_children == null) {
                 _children = new ArrayList<>();

diff --git a/flying-saucer-pdf/src/main/java/org/xhtmlrenderer/pdf/ITextOutputDevice.java b/flying-saucer-pdf/src/main/java/org/xhtmlrenderer/pdf/ITextOutputDevice.java
@@ -1027,18 +1027,15 @@ private void loadBookmark(Bookmark parent, Element bookmark) {
     }
 
     static class Bookmark {
-        private String _name;
-        private String _HRef;
-        private Box    _box;
+        private final String _name;
+        private final String _href;
+        private Box _box;
 
         private List<Bookmark> _children;
 
-        Bookmark() {
-        }
-
         Bookmark(String name, String href) {
             _name = name;
-            _HRef = href;
+            _href = href;
         }
 
         public Box getBox() {
@@ -1050,21 +1047,13 @@ public void setBox(Box box) {
         }
 
         public String getHRef() {
-            return _HRef;
-        }
-
-        public void setHRef(String href) {
-            _HRef = href;
+            return _href;
         }
 
         public String getName() {
             return _name;
         }
 
-        public void setName(String name) {
-            _name = name;
-        }
-
         public void addChild(Bookmark child) {
             if (_children == null) {
                 _children = new ArrayList<>();