feat: custom air conditioning #899
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Self note - Discuss options for a shorter title (for only the left navigation menu) |
There was a problem hiding this comment.
Woot thanks for the great PR! (forgot to add my intro) before sending the review. Have a couple suggestions and let me know if you have any questions!
Couple things TODO
- I can optimize images for you as 400kb is rather large. Will get on this sometime today.
- Is there any resolution method to the failures you've described? (beyond turning the failure off).
I would hazard the following (in relation to resolutions):
- If yes -> maybe include basic resolution steps in an admonition or just via a new section
- If no -> maybe include an admonition to simply state we will be bringing resolution methods or etc. at a later time
|
Thanks for the review @Valastiri !! I've implemented your comments and added some extra lines to break up paragraphs. I still think it looks like a lot of text and some graphs/images might help, but I don't have any ideas on what else to add 😄 Regarding your comment about the failures resolution methods. There is no way to "fix" a failed item, but I've added a comment that says |
heyo! I'll take a look tonight sorry was quite busy past couple of days. Yea that works! I wasn't entirely sure if there were should've given ya that option. That ECAM migitations sounds great! If you don't mind me committing things I'll maybe break up the text a bit and even if it's long we can iterate down the line with more media if you'd like. or we can wait. |
| # Custom Air Conditioning System | ||
|
|
||
| ## System Description | ||
| The Air Conditioning, Pressurization and Ventilation system (also known as Environmental Control System (ECS) or simply Air Conditioning System for convenience) regulates the temperature, pressure and airflow inside the aircraft. |
There was a problem hiding this comment.
| The Air Conditioning, Pressurization and Ventilation system (also known as Environmental Control System (ECS) or simply Air Conditioning System for convenience) regulates the temperature, pressure and airflow inside the aircraft. | |
| The air Conditioning, pressurization and ventilation system (also known as Environmental Control System (ECS) or simply Air Conditioning System for convenience) regulates the temperature, pressure, and airflow inside the aircraft. |
There was a problem hiding this comment.
@Sleinmaster question -- you missed the capital C for the first conditioning (intentional)?
Additionally, keeping the capitilization in the second instance yes?
|
I might review this tonight and commit changes to get this ready for merge |
|
check build |
|
Strict Build Failed! ❌ - Please checkout this PR locally to fix the issue before merging or visit the actions tab. |
|
will solve with rebase shortly with optimized images + some additional changes |
Co-authored-by: Sleinmaster <[email protected]>
Valastiri
force-pushed
the
air-conditioning
branch
from
d9f4f3f to
2fbb152
Compare
Summary
This PR adds a page under Feature Guides to define the "Custom Air Conditioning System", mainly needed to support PR flybywiresim/aircraft#8178 [Air Conditioning Failures].
My first contribution to docs so open to all comments and suggestions for improvement 😄. I'm not good at this kind of thing.
Location
docs/fbw-a32nx/feature-guides/custom-air-conditioning/
Discord username (if different from GitHub): mjuhe