Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearer logging for the role assignment handler #16

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

benw202
Copy link
Member

@benw202 benw202 commented Jan 28, 2024

Description

Gives clearer logging in the role assignment handler when the button ID doesn't match. It shows us which button was pressed and by who.

In the future, I may make this a generic button press handler, and then call logic based on what buttons are pressed. This would save us from creating more event listeners every time we need to watch for buttons.

Test Results

image

Discord Username

benw8484

@benw202 benw202 merged commit c4fc87f into flybywiresim:staging Jan 28, 2024
3 checks passed
@benw202 benw202 deleted the role-assignment-logging branch February 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants