Bug fix: Remote restores should only be eligible on uninitialized clusters #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After a cluster is restored, the
restore.lock
is set on the primary to prevent the restore from re-triggering on reboot. However, therestore.lock
is not set on the replicas so when they are rebooted the restore process will kick in and blow away the repmgr database...If you hit this issue, you will see a log on your replica saying:
Restoring from a hot standby.
, with the following logs:Solution
The restore process is now being properly restricted to uninitialized clusters. If the cluster has already been initialized, meaning the cluster's primary has been established, the restore process will be ignored.