test: add test around the polling server and fix surfaced issues #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
force-pushed
the
837-branch-planner-unit-test
branch
3 times, most recently
from
c289070 to
e476f14
Compare
The test is very simple for now: 1. Creates some basic test resources. 2. Uses a fake k8s client. 3. Uses a fake git provider. 4. Starts the polling server. 5. Waits until the branch planner resource appears. 6. Creates a replan comment. 7. Waits until the branch planner resource has "reconcile" request and placeholder comment id annotation. 8. Marks the pull request as closed. 9. Waits until the branch planner resource is deleted. That covers the basic logic. Discovered issues: 1. The isAllowedNamespace check was wrong. 2. The Source object can have nil Reference for branch. I don't know what it does, I assume it uses a default branch, but we didn't handle that. Other changes: 1. I moved the `provider.FromURL` into a Server struct level field so we can mock the provider layer. I tried to come up other ideas, but that looked the less messy. Closes #837 References: * #837 Signed-off-by: Balazs Nadasdi <[email protected]>
yitsushi
force-pushed
the
837-branch-planner-unit-test
branch
from
e476f14 to
25a7e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is very simple for now:
and placeholder comment id annotation.
That covers the basic logic.
Discovered issues:
I don't know what it does, I assume it uses a default branch, but we
didn't handle that.
Other changes:
provider.FromURLinto a Server struct level field so wecan mock the provider layer. I tried to come up other ideas, but that
looked the less messy.
Closes #837
References: