Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-core: add 0.67.0 #274

Merged
merged 3 commits into from
Jan 7, 2025
Merged

flux-core: add 0.67.0 #274

merged 3 commits into from
Jan 7, 2025

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Dec 31, 2024

Testing build for flux 0.67.0. If this triggers master and it works, we can probably safely merge. The build is enabled, but this version isn't added yet. This PR:

  • adds version 0.67.0 of flux-core
  • adds an extra step to the build test workflow to upload an artifact of the spack stage directory on failure (with the output error log)
  • adds py-setuptools for 0.67.0 upward

It takes 2.5 hours because we no longer rely on any host dependencies. There were weird errors and the spack developers said they couldn't attribute anything to the packages (and couldn't help) because we were using them, so I removed them. It fixed the error at that time, and the cost is the longer build times.

This will close #245

Copy link
Member

@trws trws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing! That's the change that we needed to support newer python, which does require setuptools but I wonder how we got in this far without setuptools available. Actually thought that was already in the spack package.

@vsoch vsoch merged commit 5617923 into main Jan 7, 2025
4 checks passed
@vsoch vsoch deleted the flux-core-0.67.0 branch January 7, 2025 22:25
@vsoch
Copy link
Member Author

vsoch commented Jan 7, 2025

Great sleuthing!

Thanks! That's me, the Sleuthy-saurus. 🦕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flux-core: 0.67.0 builds failing due to Python environment
2 participants