Support deferred job start time #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized the PR will need updating. As it stands the job will never run, because each time qmanager iterates through the jobs and reaches the deferred job it will set the at time to be n ( |
milroy
force-pushed
the
deferred-alloc
branch
4 times, most recently
from
6aa49d7 to
bc308d9
Compare
7 tasks
For upcoming Fluxion use cases users will need the capability to request a deferred allocation. The desired behavior is equivalent to match allocate_orelse_reserve, but with a request time in the future. Add DEFERRED_ORELSE_RESERVE match_op_t to provide the needed type.
Problem: the user needs to set an optional key "deferred_start" in their jobspec to specify the earliest time at which the job should start. Add capability in jobspec build function to find the optional key and set the job "at" time to the user provided value.
The DEFERRED_ORELSE_RESERVE case should behave exactly like MATCH_ALLOCATE_ORELSE_RESERVE with an "at" time set in the future. Add a "fall through" case for DEFERRED_ORELSE_RESERVE so that it executes the logic of MATCH_ALLOCATE_ORELSE_RESERVE.
The resource_match module needs to support deferred_orelse_reserve. Add a new conditional check for the "deferred_orelse_reserve" command.
Add functions and parsing for deferred_orelse_reserve RPCs and actions in flux-ion-resource.
Add functions, command parsing, and help string for deferred_orelse_reserve in resource-query.
milroy
force-pushed
the
deferred-alloc
branch
from
bc308d9 to
e3b7a96
Compare
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
========================================
+ Coverage 71.7% 74.3% +2.5%
========================================
Files 89 86 -3
Lines 11665 9448 -2217
========================================
- Hits 8374 7028 -1346
+ Misses 3291 2420 -871
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #3271 (flux-core), #987, and #963 identify useful new capability for Fluxion: to allow a user to specify a time in the future for their job to start. If the job cannot start at that time, then Fluxion should reserve the job at the earliest time.
Functionally this is very similar to "allocate_orelse_reserve" with an "at" time in the future. This PR adds the desired capability.
TODO:
deferred_startin the optional jobspec system attributes the right approach?booldetermines whethermatch_allocatealso reserves.