Fix broken links and add linkcheck back to CI #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshcorbett
previously approved these changes
Oct 23, 2024
|
Oh sorry didn't see this was a draft :| |
|
eh maybe it doesn't have to be. I'd like to get back to automating linkcheck with CI but maybe we can accomplish that in a separate pr? Thoughts, @jameshcorbett? |
|
It depends on how much work there is to be done. If you think you could do it without a ton more effort that would be nice, because the proper way to review this PR as it is now would be to manually verify that all the links work which can be tedious. |
wihobbs
force-pushed
the
links
branch
3 times, most recently
from
4254009 to
8ab9b98
Compare
Problem: there are a lot of broken links in our docs. Fix them.
Problem: our links have become stale due to not enforcing sphinx's linkcheck option in CI. Add that back in. Fixes flux-framework#284
wihobbs
changed the title
|
Thanks @jameshcorbett! I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: there are some broken links in our docs.
Fix them.