-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorials: make CORAL example consistent #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Problem: the CORAL interactive tutorial uses the username "elvis" in all places but one. Solution: make the document consistent by removing the last reference to "hobbs17" and replacing with "elvis".
After running
hobbs@hobbs-mbp:~/flux-docs$ git diff auto_examples/index.rst
diff --git a/auto_examples/index.rst b/auto_examples/index.rst
index be13a05..24218aa 100644
--- a/auto_examples/index.rst
+++ b/auto_examples/index.rst
@@ -22,6 +22,7 @@ of using the Flux Python API.
<div class="sphx-glr-thumbnails">
+.. thumbnail-parent-div-open
.. raw:: html
@@ -40,6 +41,8 @@ of using the Flux Python API.
</div>
+.. thumbnail-parent-div-close
+
.. raw:: html
</div> I don't understand why elvis should be causing this, and I'm not comfortable adding compressed zipped folders to a PR until I understand what they're doing. The underlying files do not differ:
|
you could say I don't "git" it |
I tried restarting the failed job to see if it would generate any kind of specific error:
I wonder why |
I don't think these problems have anything to do with any changes:
That's off of Also worth noting that @jameshcorbett wasn't hitting this problem 2 days ago. Could the sphinx-gallery v0.17.1 release from 3 days ago have anything to do with this? When I looked more closely at the |
Hmm. Interesting. My working theory is that some change was made to sphinx-gallery v0.17.1 that requires these new tags to make the gallery render. |
@vsoch, added you as an approving reviewer since we've had some back and forth about the auto-examples. |
Not two days ago--I merged the PR two days ago but the action ran four months ago (it was an old PR I forgot to merge). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Problem: sphinx-gallery has rolled some updates in the last few months. As a working theory, one of these updates might have required a new div in the auto-generated gallery we use for displaying examples. Update that gallery's index.rst to get the CI working again.
Whoops. Ok, well, if we need to go back and fix we can. I don't think this really did anything drastic. |
Problem: the CORAL interactive tutorial uses the username "elvis" in all places but one.
Solution: make the document consistent by removing the last reference to "hobbs17" and replacing with "elvis".