libsubprocess: cosmetic cleanup #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the bulk-exec code for sdexec includes a comment referencing "imp kill", but that IMP subcommand was dropped. Drop the example from the comment.
Problem: bulk_exec_imp_kill() was removed but its prototype remains. Drop the function prototype and a comment reference to it.
Problem: some line breaks in a bulk-exec test do not conform to RFC 7. Break long parameter lists to one per line at the same indent level.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6642 +/- ##
==========================================
- Coverage 83.88% 83.87% -0.01%
==========================================
Files 533 533
Lines 88372 88372
==========================================
- Hits 74127 74119 -8
- Misses 14245 14253 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies up some minor stuff in
bulk-exec.[ch]and its test program. Purely cosmetic.