flux-job: do not override -L, --color when -H, --human is used in eventlog and wait-event subcommands
#6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The `-H, --human` option of `flux job eventlog` and `flux job wait-event` forces `--color=auto`, but this breaks usage like `-HL` to force color on (e.g. if passed to `less`). Do not overwrite the color option with `--human`. The default is already `auto`, so there's no need.
Problem: The `flux job wait-event` and `eventlog` tests do not ensure that the options `-HL` enable human timestamps but also force color. Add this option usage to existing tests that check that color is force-enabled.
|
Thanks! Setting MWP |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6612 +/- ##
==========================================
- Coverage 79.52% 79.51% -0.01%
==========================================
Files 531 531
Lines 88354 88353 -1
==========================================
- Hits 70264 70257 -7
- Misses 18090 18096 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something else I discovered that
flux job eventlog -HL ...wasn't forcing color on like it should. This is because-H, --humanforcescolor = auto, overwriting the user's command line choice.autois already the default. Stop doing that.Add a test.