edit-user: make fairshare an editable field for an association
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
Problem: The "fairshare" column in the association_table should be made an editable column by admins, but right now it doesn't have the right infrastructure in the database to do so because there is no reset of a value in the case where a 'NOT NULL' constraint fails, similar to the other editable fields in the association_table. Add a "ON CONFLICT" clause to the fairshare column in the association_table to match the other editable fields. Update the DB schema to reflect the update to the association_table.
Problem: Since admins are the only ones who have privileges to run the edit-user command, they should be able to edit the fairshare column for an association manually if they so choose, but there is currently no way to do so via flux-accounting command; they have to connect to a SQLite shell and create and execute a SQL statement to update the column manually. Add the fairshare column as an editable field in the edit-user command.
Problem: There exists no tests for editing the fairshare column for an association. Add some basic unit and sharness tests.
cmoussa1
force-pushed
the
add.edit.fair-share
branch
from
0290841 to
c291557
Compare
|
Thanks @jameshcorbett! Rebased to catch up after #570; setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since admins are the only ones who have privileges to run the
edit-usercommand, they should be able to edit thefairsharecolumn for an association manually if they so choose, but there is currently no way to do so viaedit-user; they have to connect to a SQLite shell and create and execute a SQL statement to update the column manually.This PR makes the
fairsharecolumn an optional argument in theedit-usercommand. I've updated thefairsharecolumn in theassociation_tableto match the other editable fields, as well as added a unit and sharness test.