association_table: add max_cores attribute, send information to plugin
#560
Conversation
Problem: The association_table has no way to track the max number of cores an association can have across all of their running jobs. This is needed in order to track the max number of resources an association has across all of their running jobs. Add a new column to the association_table called "max_cores". Update the schema version number for the flux-accounting database to account for the new column addition.
Problem: max_cores is an attribute for every row in the association_table, but it cannot be configured with the add-user and edit-user commands. Add max_cores as a configurable field in the add-user and edit-user commands.
Problem: The flux-accounting database from before the addition of the "max_cores" column is not in the testsuite, but it should be a part of the update-db tests since the schema has changed. Add the flux-accounting DB schema version 24 to the testsuite.
Problem: The priority plugin does not store max_cores information per-association in the plugin, which it will need in order to do resource tracking across all of an association's running jobs. Add max_cores to the list of information sent to the priority plugin per-association. Add max_cores as an attribute to the Association class so that it can be stored and accessed per-association in the plugin. Set a default for this attribute when creating a temporary association in the plugin. Edit the accounting.cpp unit test to account for the addition of the new max_cores attribute.
cmoussa1
added
new feature
There was a problem hiding this comment.
Looks good! I don't really understand 9f04c00 but that's probably OK 😊
|
Thanks @jameshcorbett - that commit is just giving an admin (or whoever is using flux-accounting) the ability to configure the |
|
Sorry I copied the wrong SHA I meant 6b4210a. |
|
OH, oh I gotcha - that commit is adding the DB schema before adding the new |
|
Got it that makes sense! |
|
Thanks!! Okay, setting MWP here |
Problem
The
association_tablehas no way to track the max number of cores an association can have across all of their running jobs. This is needed in order to track the max number of resources an association has across all of their running jobs.This PR adds a new column to the
association_tablecalledmax_cores. This field is configurable both when adding or editing an association in the flux-accounting database. This attribute is added to the rest of the information sent per-association to the priority plugin, where it is stored as another member in theAssociationclass.Existing tests are updated to account for the addition of the new column, and the flux-accounting database from the previous schema version is also added to the testsuite now that the schema has been updated.