list-banks: use AccountingFormatter class
#524
Merged
+32
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
cmoussa1
force-pushed
the
restructure.list-bank
branch
from
0ec0fe0 to
5007c4e
Compare
Problem: The list-banks command defines its own formatting for the output of the command, but the Python bindings now has its own common formatter and SQL utilities. Edit the list-banks command to make use of the new formatter and external Python utilities. Change the default for the --fields optional argument to be None if it is not specified.
cmoussa1
force-pushed
the
restructure.list-bank
branch
from
5007c4e to
6c0dcfb
Compare
|
Thanks @wihobbs!! Rebased to catch up. Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
list-bankscommand defines its own formatting for the output of the command, but the Python bindings now has its own common formatter and SQL utilities.This PR edits the
list-bankscommand to make use of the new formatter and external SQLite utilities. It also changes the default for the--fieldsoptional argument to beNoneif it is not specified.