Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__init__.py: fix formatting of constants #521

Merged
merged 1 commit into from
Oct 29, 2024
Merged

__init__.py: fix formatting of constants #521

merged 1 commit into from
Oct 29, 2024

Conversation

cmoussa1
Copy link
Member

Problem

The constants defined in __init__.py for the flux-accounting Python package are formatted incorrectly and are flagged by pylint. They should be in all caps:

__init__.py:1:0: C0103: Constant name "db_dir" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(__.*__))$' pattern (invalid-name)
__init__.py:2:0: C0103: Constant name "db_path" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(__.*__))$' pattern (invalid-name)
__init__.py:3:0: C0103: Constant name "db_schema_version" doesn't conform to '(([A-Z_][A-Z0-9_]*)|(__.*__))$' pattern (invalid-name)

This PR fixes the format of the constants defined in __init__.py and changes the references to these constants throughout the Python package to account for the change.

@cmoussa1
__init__.py: fix formatting of constants
c1b30d2 
Problem: The constants defined in __init__.py for the flux-accounting
Python package are formatted incorrectly. They should be in all caps.

Fix the format of the constants defined in __init__.py. Change the
references to these constants throughout the Python package to account
for the change.
@cmoussa1 cmoussa1 added low priority items that can be worked on at a later date bug-fix A proposal for something that isn't working labels Oct 28, 2024
jameshcorbett
jameshcorbett approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jameshcorbett jameshcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmoussa1
Copy link
Member Author

Thanks @jameshcorbett! setting MWP here

@mergify mergify bot merged commit c2399c8 into flux-framework:master Oct 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshcorbett jameshcorbett jameshcorbett approved these changes

Assignees
No one assigned
Labels
bug-fix A proposal for something that isn't working low priority items that can be worked on at a later date merge-when-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoussa1 @jameshcorbett