plugin: add callback prefixes to exception messages #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The priority plugin uses the same exception message in more than one callback because there is more than one instance where that message would be appropriate. However, these exception messages are not prefixed with the callback the exception is being raised from, which can make it hard to debug when looking at a job's eventlog. Add a prefix of the name of the callback the exception message is coming from.
|
Thanks @jameshcorbett! Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The priority plugin uses the same exception message for jobspec updates in more than one callback because there is more than one instance where that message would be appropriate. However, these exception messages are not prefixed with the callback the exception is being raised from, which can make it hard to debug when looking at a job's eventlog.
This PR just adds a prefix of the name of the callback the exception message is coming from.