testsuite: fix on systems with flux-accounting already installed #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
approved these changes
Jul 10, 2024
|
I'll set MWP. thanks. |
Problem: When flux-accounting is already installed on a system, the sharness tests pull in the installed version of flux-accounting Python modules instead of the test version. This occurs because sharness prepends the source tree Python path to PYTHONPATH, which is then subverted by flux-core's `py-runner.py`, which prepends the system path in front of that before executing Python subcommands like the accounting service etc. Use FLUX_PYTHONPATH_PREPEND instead of PYTHONPATH, which is preserved by the py-runner.py wrapper.
grondo
force-pushed
the
t-pythonpath-prepend
branch
from
6e53b1e to
30c195a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When flux-accounting is already installed on a system, the sharness tests pull in the installed version of flux-accounting Python modules instead of the test version. This occurs because sharness prepends the source tree Python path to PYTHONPATH, which is then subverted by flux-core's
py-runner.py, which prepends the system path in front of that before executing Python subcommands like the accounting service etc.Use FLUX_PYTHONPATH_PREPEND instead of PYTHONPATH, which is preserved by the py-runner.py wrapper.