Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t: update descriptions of sharness tests #447

Merged
merged 1 commit into from
May 9, 2024

Conversation

cmoussa1
Copy link
Member

@cmoussa1 cmoussa1 commented May 8, 2024

Problem

Some of the descriptions of the sharness tests in flux-accounting are misleading because they were copied over from another test file and were never updated.


This PR updates the descriptions of a number of the sharness tests.

Problem: Some of the descriptions of the sharness tests in
flux-accounting are misleading because they were copied over from
another test file and were never updated.

Update the descriptions of a number of the sharness tests.
@cmoussa1 cmoussa1 added the testing issues that deal with testing label May 8, 2024
@cmoussa1 cmoussa1 requested a review from wihobbs May 8, 2024 18:22
Copy link
Member

@wihobbs wihobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmoussa1
Copy link
Member Author

cmoussa1 commented May 9, 2024

Thanks @wihobbs! Setting MWP here

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (20bb6fc) to head (2f811cf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          23       23           
  Lines        1545     1545           
=======================================
  Hits         1287     1287           
  Misses        258      258           

@mergify mergify bot merged commit e5f409b into flux-framework:master May 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing testing issues that deal with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants