t1029: remove brackets from grep tests
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The priority jobtap plugin will soon support jobspec-updates of
both banks and projects, and the "jobspec-update" event in the eventlog
holds both of these updates on one line, which breaks the assumption in
t1029-mf-priority-default-bank.t that the jobspec-update of a user's
default bank will be surrounded by brackets {}.
Remove the outer brackets from the tests in
t1029-mf-priority-default-bank.t that grep for a certain bank.
cmoussa1
added
improvement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 23 23
Lines 1457 1457
=======================================
Hits 1215 1215
Misses 242 242 |
|
thanks! setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was working on re-implementing project support in the plugin and noticed this commit that could be broken off
Problem
The priority jobtap plugin will soon support
jobspec-updates of both banks and projects, and thejobspec-updateevent in the eventlog holds both of these updates on one line, which breaks the assumption int1029-mf-priority-default-bank.tthat thejobspec-updateof a user's default bank will be surrounded by brackets{}.Remove the outer brackets from the tests in
t1029-mf-priority-default-bank.tthatgrepfor a certain bank.