Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLUID-5098: Identify ToC container in demos #1108

Merged
merged 4 commits into from
Dec 4, 2024
Merged

FLUID-5098: Identify ToC container in demos #1108

merged 4 commits into from
Dec 4, 2024

Conversation

jobara
Copy link
Member

@jobara jobara commented Jul 31, 2024

  • Adds comments to highlight the ToC container in demos
  • Changes the ToC to be a <nav> element
  • Updates the code to label the ToC container which is now often going to be a <nav> element.

@jobara jobara requested a review from amb26 July 31, 2024 17:49
@jobara jobara requested a review from greatislander November 26, 2024 12:09
@greatislander greatislander merged commit 41fe77a into fluid-project:main Dec 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatislander greatislander greatislander approved these changes

@amb26 amb26 Awaiting requested review from amb26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobara @greatislander