Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax required Nokogiri version #117

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Feb 5, 2025

  • Nokogiri 1.18.2 (Ruby >= 3.1)
  • Nokogiri 1.17.x (Ruby >= 3.0)
  • Nokogiri 1.16.8 (Ruby >= 3.1)
  • Nokogiri 1.16.7 (Ruby >= 3.0)

Passed:

Ruby 3.2 + Nokogiri 1.18.0
Ruby 3.1 + Nokogiri 1.16.8
Ruby 3.0 + Nokogiri 1.16.8
Ruby 2.7 + Nokogiri 1.15.7

* Nokogiri 1.18.2 (Ruby >= 3.1)
* Nokogiri 1.17.x (Ruby >= 3.0)
* Nokogiri 1.16.8 (Ruby >= 3.1)
* Nokogiri 1.16.7 (Ruby >= 3.0)

Since strict version limitation was introduced via the following commit,

  Permit using nokogiri 1.11.0
  fluent#54

but it seems no need to apply it.

Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom daipom merged commit 61fa050 into fluent:master Feb 5, 2025
6 checks passed
@kenhys kenhys deleted the relax-nokogiri branch February 5, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants