Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformMessage not applying properly in AnyRule. #11

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

ibrahim-mubarak
Copy link
Contributor

Description

This PR fixes transformMessage not applying properly in AnyRule

Related Issue

#9

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #11 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #11   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           12     12           
  Lines           77     77           
======================================
  Hits            77     77
Impacted Files Coverage Δ
lib/src/rules/any_rule.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf0bda...7f7dda0. Read the comment docs.

@shbmbhrdwj shbmbhrdwj merged commit 1cab3af into develop Nov 18, 2019
@ibrahim-mubarak ibrahim-mubarak deleted the feature/fix-transform-message-for-any-rule branch November 18, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants