Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime server url setting #47

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

haiphucnguyen
Copy link
Contributor

🛠 Description

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

✅ How Has This Been Tested?

  • Test A
  • Test B

📝 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

📸 Screenshots (optional)

If you made UI changes, what are the before an afters?

💬 Further Comments:

@haiphucnguyen haiphucnguyen force-pushed the feature/runtime-server-url-setting branch from 132b3b9 to 4a46d8f Compare December 26, 2024 09:09
@haiphucnguyen haiphucnguyen force-pushed the feature/runtime-server-url-setting branch from 4a46d8f to b52049c Compare December 26, 2024 09:13
@haiphucnguyen haiphucnguyen merged commit 32b9e7a into main Dec 27, 2024
2 checks passed
@haiphucnguyen haiphucnguyen deleted the feature/runtime-server-url-setting branch December 27, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant