fix to add variables which are not string through the .variable(...) …

…method
flowable · Jan 16, 2025 · a760070 · a760070
1 parent bb92b60
commit a760070
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/external-worker-client.spec.ts b/src/external-worker-client.spec.ts
@@ -148,7 +148,8 @@ describe('ExternalWorkerClient', () => {
                 callbackHandler(acquiredJob: ExternalWorkerAcquireJobResponse, workResultBuilder: WorkerResultBuilder) {
                     job = acquiredJob;
                     return workResultBuilder.success()
-                        .variable('testVar', 'test content', 'string');
+                        .variable('testVar', 'test content', 'string')
+                        .variable('testVar2', 12, 'integer');
                 },
                 waitPeriodSeconds: 0.2
             });

diff --git a/src/external-worker-client.ts b/src/external-worker-client.ts
@@ -8,6 +8,7 @@ import {
     FlowableExternalWorkerRestClient
 } from "./rest-client";
 import {ExternalWorkerAcquireJobResponse} from "./external-worker-acquire-job-response";
+import { EngineRestVariableType } from "./engine-rest-variable";
 
 export class ExternalWorkerClient {
 
@@ -112,7 +113,7 @@ export class WorkerResultSuccess implements WorkResult {
         this.completeJobParams = {jobId: job.id, variables: null};
     }
 
-    public variable(name: string, value: string, type: string): WorkerResultSuccess {
+    public variable(name: string, value: any, type: EngineRestVariableType | string): WorkerResultSuccess {
         this.completeJobParams.variables = this.completeJobParams.variables || [];
         this.completeJobParams.variables.push({name, value, type, valueUrl: null});
         return this;
@@ -164,7 +165,7 @@ export class WorkerResultBpmnError implements WorkResult {
         this.bpmnErrorParams = {jobId: job.id};
     }
 
-    public variable(name: string, value: string, type: string): WorkerResultBpmnError {
+    public variable(name: string, value: any, type: EngineRestVariableType | string): WorkerResultBpmnError {
         this.bpmnErrorParams.variables = this.bpmnErrorParams.variables || [];
         this.bpmnErrorParams.variables.push({name, value, type, valueUrl: null});
         return this;
@@ -187,7 +188,7 @@ export class WorkerResultCmmnTerminate implements WorkResult {
         this.cmmnTerminateParams = {jobId: job.id};
     }
 
-    public variable(name: string, value: string, type: string): WorkerResultCmmnTerminate {
+    public variable(name: string, value: any, type: EngineRestVariableType | string): WorkerResultCmmnTerminate {
         this.cmmnTerminateParams.variables = this.cmmnTerminateParams.variables || [];
         this.cmmnTerminateParams.variables.push({name, value, type, valueUrl: null});
         return this;

diff --git a/src/fixtures/complete-job-request.json b/src/fixtures/complete-job-request.json
@@ -6,6 +6,12 @@
       "type": "string",
       "value": "test content",
       "valueUrl": null
+    },
+    {
+      "name": "testVar2",
+      "type": "integer",
+      "value": 12,
+      "valueUrl": null
     }
   ]
 }