Update example to use new func RegisterWithErrorFunc #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
reviewed
Dec 29, 2023
| @@ -42,11 +43,10 @@ func ExampleNfqueue_Register() { | |||
| } | |||
|
|
|||
| // Register your function to listen on nflqueue queue 100 | |||
| err = nf.Register(ctx, fn) | |||
There was a problem hiding this comment.
Replacing the deprecated function Register() with RegisterWithErrorFunc() in the example is a good idea. But we should keep the error handling.
giulianopz
force-pushed
the
main
branch
2 times, most recently
from
b5c05a1 to
fee052f
Compare
|
done! |
florianl
reviewed
Dec 30, 2023
example_test.go
Outdated
Comment on lines
46
to
49
| err = nf.RegisterWithErrorFunc(ctx, fn, func(e error) int { | ||
| if err != nil { | ||
| fmt.Println(err) | ||
| return -1 | ||
| } | ||
| return 0 | ||
| }) |
There was a problem hiding this comment.
If ErrorFunc is called in the scope of RegisterWithErrorFunc(), then error is never nil.
But RegisterWithErrorFunc() also returns an error, e.g. if the hook can not be registered to the socket. Then this error should not be ignored.
Suggested change
| err = nf.RegisterWithErrorFunc(ctx, fn, func(e error) int { | |
| if err != nil { | |
| fmt.Println(err) | |
| return -1 | |
| } | |
| return 0 | |
| }) | |
| err = nf.RegisterWithErrorFunc(ctx, fn, func(e error) int { | |
| fmt.Println(err) | |
| return -1 | |
| }) | |
| if err != nil { | |
| fmt.Println(err) | |
| return | |
| } |
There was a problem hiding this comment.
Sorry, I misunderstood your original request. Changed as suggested.
There was a problem hiding this comment.
Thanks for the update - it was my mistake not to be precious about my requested changes.
Signed-off-by: giuliano <[email protected]>
florianl
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.