fix: Use dagger to detect the arch and platform in stead of go runtime #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Mask <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dagger-platform #655 +/- ##
================================================
Coverage 85.60% 85.60%
================================================
Files 7 7
Lines 3910 3910
================================================
Hits 3347 3347
Misses 563 563 ☔ View full report in Codecov by Sentry. |
markphelps
added a commit
that referenced
this pull request
Jan 27, 2025
* chore: try to fix issue with dagger and host platform Signed-off-by: Mark Phelps <[email protected]> * fix: Use dagger to detect the arch and platform in stead of go runtime (#655) Signed-off-by: Ben Mask <[email protected]> --------- Signed-off-by: Mark Phelps <[email protected]> Signed-off-by: Ben Mask <[email protected]> Co-authored-by: Ben Mask <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markphelps Here are my changes to go into your branch if you are okay with them.