Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not fail on non-existent namespace in Rust core #26

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

yquansah
Copy link
Contributor

@yquansah yquansah commented Dec 7, 2023

Makes a variety of changes.

  1. Do not return errors from parsing the HTTP response which has a trickle effect to the engine
  2. Modify tests to account for error case when passing in a 'nonexistent' flag

Completes FLI-730

Copy link

linear bot commented Dec 7, 2023

FLI-730 Bug: panic on notfound namespace

https://github.com/flipt-io/client-sdks/actions/runs/7120260245/job/19387131032

"grpc.service": "flipt.evaluation.DataService", "grpc.method": "EvaluationSnapshotNamespace", "peer.address": "127.0.0.1:52166", "error": "rpc error: code = NotFound desc = getting flags: namespace \"`CXN3V\" not found", "grpc.code": "NotFound", "grpc.time_ms": 0.426}
76: ...

127: exec bundle exec rspec ERROR: process "bundle exec rspec" did not complete successfully: exit code: 255
127: [0.58s] Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
127: [1.27s] thread '<unnamed>' panicked at flipt-engine/src/lib.rs:189:50:
127: [1.27s] called `Result::unwrap()` on an `Err` value: Whatever { source: None, message: "failed to deserialize response into document: err missing field `namespace` at line 1 column 81", backtrace: Backtrace(()) }

@yquansah yquansah requested a review from markphelps December 7, 2023 14:38
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! ty

@markphelps markphelps enabled auto-merge (squash) December 7, 2023 14:55
@yquansah
Copy link
Contributor Author

yquansah commented Dec 7, 2023

@markphelps ruby.... 😞

@markphelps markphelps merged commit 51ef54b into main Dec 7, 2023
5 checks passed
@markphelps markphelps deleted the code-resilience branch December 7, 2023 15:24
markphelps added a commit that referenced this pull request Dec 7, 2023
* main:
  feat: do not fail on non-existent namespace in Rust core (#26)
  chore: address comments
  chore: remove unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants