Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine-ffi): return error to caller on connection or parse json failures #254

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Apr 24, 2024

resolves #253

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 94.24460% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.90%. Comparing base (f562a7d) to head (2a55f37).

Files Patch % Lines
flipt-engine-ffi/src/evaluator/mod.rs 94.82% 6 Missing ⚠️
flipt-engine-ffi/src/parser/http.rs 0.00% 1 Missing ⚠️
flipt-evaluation/src/parser/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   82.29%   85.90%   +3.60%     
==========================================
  Files          11       11              
  Lines        3152     3277     +125     
==========================================
+ Hits         2594     2815     +221     
+ Misses        558      462      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the connection-failure branch 2 times, most recently from 866270e to 35eb1bb Compare April 26, 2024 20:03
@erka erka marked this pull request as ready for review April 26, 2024 20:45
@erka erka requested a review from a team as a code owner April 26, 2024 20:45
@erka erka force-pushed the connection-failure branch 5 times, most recently from d58c642 to 65f9887 Compare April 27, 2024 14:44
@markphelps
Copy link
Contributor

markphelps commented Apr 27, 2024

Closes: #253

Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers thanks @erka ! one minor nit about naming of the empty state method for Snapshot

flipt-engine-ffi/src/evaluator/mod.rs Outdated Show resolved Hide resolved
flipt-engine-ffi/src/evaluator/mod.rs Outdated Show resolved Hide resolved
@erka erka force-pushed the connection-failure branch from cf7a18a to 1aa1616 Compare April 27, 2024 18:07
@erka erka force-pushed the connection-failure branch from 1aa1616 to 2a55f37 Compare April 27, 2024 18:08
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! ty!!

@kodiakhq kodiakhq bot merged commit aaf3377 into flipt-io:main Apr 27, 2024
11 checks passed
@flipt-release-bot flipt-release-bot bot mentioned this pull request Apr 27, 2024
@erka erka deleted the connection-failure branch April 27, 2024 19:07
@flipt-release-bot flipt-release-bot bot mentioned this pull request Aug 25, 2024
@flipt-release-bot flipt-release-bot bot mentioned this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-969] Return error to caller after X times of failed connection
3 participants