-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine-ffi): return error to caller on connection or parse json failures #254
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 82.29% 85.90% +3.60%
==========================================
Files 11 11
Lines 3152 3277 +125
==========================================
+ Hits 2594 2815 +221
+ Misses 558 462 -96 ☔ View full report in Codecov by Sentry. |
866270e
to
35eb1bb
Compare
d58c642
to
65f9887
Compare
Closes: #253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers thanks @erka ! one minor nit about naming of the empty state method for Snapshot
cf7a18a
to
1aa1616
Compare
failures Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
1aa1616
to
2a55f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! ty!!
resolves #253