Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated button panel #4064

Closed
wants to merge 4 commits into from
Closed

updated button panel #4064

wants to merge 4 commits into from
+24 −14

Conversation

Akiva-Cohen
Copy link

@Akiva-Cohen Akiva-Cohen commented Jan 8, 2025 •
edited
Loading

What's new

  • Updated button panel callbacks to make them consistent with button menu
  • Button panel now passes 3 arguments to a button callback instead of 2, the third being an InputType
  • Also updated the infrared universal remotes to work with the new code.

Verification

  • Make an app with button panel to verify it works.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

Idea is good, but please don't submit broken PRs.

@skotopes skotopes closed this Feb 13, 2025
@Akiva-Cohen
Copy link
Author

Can you give more detail about what "broken" means

@skotopes
Copy link
Member

try to build your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akiva-Cohen @skotopes