nfc: Enable MFUL sync poller to be provided with passwords #4050
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ typedef struct { | |||
| FuriThreadId thread_id; | |||
| MfUltralightError error; | |||
| MfUltralightPollerContextData data; | |||
| const MfUltralightPollerAuthContext* auth_context; | |||
There was a problem hiding this comment.
mf_ultralight_poller_sync_read_card is used in unit_tests only and why to add new parameter here, if this function is then called with NULL populated in this parameter?
There was a problem hiding this comment.
Although there are no system usages of mf_ultralight_poller_sync_read_card currently, it is exposed as an API available for user apps and NFC plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
MfUltralightPollerAuthContextwithskip_authset tofalseand the required password/3DES key. The card should automatically be unlocked during reading.Checklist (For Reviewer)
Sidenote: why not make a separate struct just for passing passwords? Because for some reason the same struct is being used to supply passwords for MFUL elsewhere, even when most of its members aren't used. It's kind of weird.