#2488 : API for in/out download from a list of processingIds #2523
Conversation
|
Some tests have been modified for allowing "extends" implementation. When a class is extended by an other one, all its @Autowired variable class declaration need to get @qualifier, for knowing which bean load among the extended class and the extension class beans (usefull when there are multiple extensions class of the same extended class, those extensions class are not implementing the same methods ...) |
|
Extraction can now be realized with examination ids instead of processing ids. Refer to the https://github.com/fli-iam/py_noir/issues/6 feature. |
…re accuracy (here, removing SIMS processing)
shanoir-ng-datasets/src/main/java/org/shanoir/ng/processing/controler/DatasetProcessingApi.java
Outdated
Show resolved
Hide resolved
shanoir-ng-datasets/src/main/java/org/shanoir/ng/processing/controler/DatasetProcessingApi.java
Outdated
Show resolved
Hide resolved
...tasets/src/main/java/org/shanoir/ng/processing/controler/DatasetProcessingApiController.java
Outdated
Show resolved
Hide resolved
...tasets/src/main/java/org/shanoir/ng/processing/controler/DatasetProcessingApiController.java
Outdated
Show resolved
Hide resolved
...atasets/src/main/java/org/shanoir/ng/processing/service/ProcessingDownloaderServiceImpl.java
Outdated
Show resolved
Hide resolved
shanoir-ng-datasets/src/main/java/org/shanoir/ng/dataset/security/DatasetSecurityService.java
Outdated
Show resolved
Hide resolved
|
When merging this PR, please check the potential merge of those 2 associated py_noir PR : |
There was a problem hiding this comment.
Dear Guewen,
really good job! Thank you a lot!
Now it looks fine for me. I approve by code review only. I did not test locally
as I do not take the time to set up everything. It would be great, if you could
make me a demo on Friday morning, using qualif please. Thank you, Michael
#2488 : API for in/out download from a list of processingIds
This PR is only relative to the creation of an API, there isn't any Shanoir interface yet, and it's currently specific to CometeMoelle project. Please be aware of the fli-iam feature, which implements a python script for generating API calls to that new API
(Tested in local and in qualif)