Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fli iam#1884] Execution monitoring as parent of processing #1946

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

youennmerel
Copy link
Collaborator

@youennmerel youennmerel commented Nov 14, 2023

@youennmerel youennmerel marked this pull request as draft November 15, 2023 09:32
@youennmerel youennmerel added REVIEWABLE Has to be reviewed and removed WorkInProgress labels Nov 24, 2023
@youennmerel youennmerel marked this pull request as ready for review November 24, 2023 12:48
Copy link
Collaborator

@jcomedouteau jcomedouteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost nothing, works fine after changing the mail.

@@ -14,6 +14,7 @@

package org.shanoir.ng.processing.model;

import com.fasterxml.jackson.annotation.JsonIgnore;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless import

<div *ngIf="!descriptionLoading">
<h3>Pipeline description : </h3>
<hr>
<p class="warning"><i class="fas fa-exclamation-triangle"></i>Please select a pipeline to see it's description!</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its

@youennmerel
Copy link
Collaborator Author

Hi @jcomedouteau,

Thx for the review, i tooks your comments into account.

@youennmerel
Copy link
Collaborator Author

@jcomedouteau
Corrected the SQL script sequence number, seems all right now

@jcomedouteau jcomedouteau merged commit 29c3774 into fli-iam:develop Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REVIEWABLE Has to be reviewed
Projects
None yet
2 participants