#1920 - remove timeout logic for import and augment timeout #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcomedouteau
commented
Oct 25, 2023
jcomedouteau
commented
- set timeout to 5mn
- Apply timeout only for download
| @@ -157,6 +159,8 @@ export class MassDownloadService { | |||
| } else { | |||
| directoryHandlePromise = this.getFolderHandle(); | |||
| } | |||
| let path :string = "Datasets-" + formatDate(new Date(), "yyyyMMddHHmmss", "en-US") + '/'; | |||
There was a problem hiding this comment.
Would break the retry functionality imo.
I'm working on it.
There was a problem hiding this comment.
Ah yes, I did not think of this. Maybe you were right, this upper folder is not the greatest idea
| @@ -42,7 +42,7 @@ export class NotificationsService { | |||
| readonly readInterval: number = 1000; | |||
| readonly persistenceTime: number = 1800000; | |||
| private freshTimeouts: SuperTimeout[] = []; | |||
| private readonly TIMEOUT: number = 30000; | |||
| private readonly TIMEOUT: number = 300000; | |||
There was a problem hiding this comment.
We had problem with the timeout, sometimes it takes more than 30sc to be updated.
The other problem was that this was applied for others jobs, taht weren't download, and import always finished as "timeout" before the end of he import
|
I'm closing this one, as this is integrated in Julien's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.